Conversation
juliusknorr
commented
Jun 16, 2020
| ], | ||
| toDOM: node => ['a', { | ||
| ...node.attrs, | ||
| title: node.attrs.href, |
Member
Author
There was a problem hiding this comment.
This line is the only difference to the tiptap implementation
Member
Author
There was a problem hiding this comment.
ChristophWurst
approved these changes
Jun 16, 2020
Member
Author
|
/compile / |
Member
Author
|
/backport 610bb51 to stable19 |
Member
Author
|
/backport 610bb51 to stable18 |
Member
Author
|
/backport 610bb51 to stable17 |
Member
Author
|
/compile amend / |
Member
|
Seems to need a rebase? |
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
bugfix/noid/link-hover
branch
from
f701cb3 to
8ddd265
Compare
|
The backport to stable19 failed. Please do this backport manually. |
|
The backport to stable18 failed. Please do this backport manually. |
|
The backport to stable17 failed. Please do this backport manually. |
Member
Author
|
/backport 3ee4f55 to stable19 |
Member
Author
|
/backport 3ee4f55 to stable18 |
Member
Author
|
/backport 3ee4f55 to stable17 |
This was referenced Jun 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise the user cannot determine the URL of the link before clicking.
This is a temporary fix until #687 is resolved, unforunately tiptap does not yet offer a way to show the menububble that we use for link editing if the link just has a cursor in it when clicking. Therefore we cannot use that to show the url in there as shown here