Migrate to playwright to update cypress#8223
Merged
max-nextcloud merged 45 commits intostable32from Jan 31, 2026
Merged
Conversation
118efab to
2aafbf3
Compare
I was sick of debugging flaky Cypress tests, so I gave Playwright a try. Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Preparing for multi context scenarios such as shared files. Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
It is included in uploadFileTest and sharedFileTest Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
For parameter properties see https://www.typescriptlang.org/docs/handbook/2/classes.html#parameter-properties For the lint exception see https://typescript-eslint.io/rules/no-useless-constructor/ Signed-off-by: Max <max@nextcloud.com>
Include a host identifier in the test name so the screenshot name also includes it. This way screenshots will only be compared to the ones created on the same machine. Only track the CI ones in git. Ignore the others. > Having different screenshots between local and docker environments is expected. > You can only compare screenshots that are taken in the same exact environment, OS, fonts, etc. See microsoft/playwright#20366 (comment) Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Jonas <jonas@freesources.org>
…acter Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Max <max@nextcloud.com>
There are no buttons that we would need to leave room for. This way the print view looks the same between editable and readonly shares. Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Signed-off-by: Max <max@nextcloud.com>
ca42de3 to
2df1049
Compare
mejo-
approved these changes
Jan 31, 2026
Member
mejo-
left a comment
There was a problem hiding this comment.
Thanks for tackling this! Nice side-effect is that we can mark playwright as required in the branch protection rules once we dropped 31 support (next month 31 becomes EOL).
Signed-off-by: Max <max@nextcloud.com>
Collaborator
Author
|
/backport to stable31 please |
2 tasks
Collaborator
Author
How about we backport this to stable31 as well? It's 99% changes to tests and might be helpful to keep tests running on stable31 in case we need to backport fixes to it later on. |
max-nextcloud
added a commit
that referenced
this pull request
Feb 1, 2026
Our config still is in vite.config This was a leftover from the backport in #8223. Signed-off-by: Max <max@nextcloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cypress 13 uses a browser so outdated it's not supported by Nextcloud anymore.
Many cypress tests fail with cypress 15 with browser crashes.
Backport the commits that migrate these tests to playwright.
Upgrade cypress to version 15.