chore(split): SourceView from ViewerComponent#8037
Merged
max-nextcloud merged 1 commit intomainfrom Jan 12, 2026
Merged
Conversation
8d2577a to
0b8c9b5
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
0b8c9b5 to
e169a03
Compare
mejo-
approved these changes
Dec 15, 2025
Member
mejo-
left a comment
There was a problem hiding this comment.
Thanks for the refactoring! Out of curiosity, why did you do it? Is it part of a bigger plan? Or just something that caught your eye and cried for a component split? 😊
Code changes look good to me. I didn't test but guess you did. I have two small comments/questions.
Collaborator
Author
Signed-off-by: Max <max@nextcloud.com>
e169a03 to
bdc845b
Compare
Collaborator
Author
|
Versions playwright spec is known to fail due to nextcloud/viewer#3046 |
max-nextcloud
added a commit
that referenced
this pull request
Jan 22, 2026
Follow up for #8037. Signed-off-by: Max <max@nextcloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.