Merged
Conversation
4 tasks
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
silverkszlo
force-pushed
the
add-table-node
branch
from
c8f5d57 to
b11dca0
Compare
Collaborator
max-nextcloud
left a comment
max-nextcloud
left a comment
There was a problem hiding this comment.
Looks good but I have not tested it.
Since you are not using collaboration might be possible to write a playwright component test for this that calls createTable() for a div or so. That would make testing it easier.
silverkszlo
force-pushed
the
add-table-node
branch
2 times, most recently
from
9474fec to
6f131b9
Compare
juliusknorr
reviewed
Dec 4, 2025
silverkszlo
force-pushed
the
add-table-node
branch
from
e3c3838 to
1a6b79a
Compare
juliusknorr
approved these changes
Dec 9, 2025
Add createTable() API to enable embedding markdown tables in other apps without rich text editing features. Introduces PlainTableDocument node that restricts content to tables only, and PlainTable extension that bundles required functionality (table editing, markdown serialization). - Add PlainTableDocument node with table-only content model - Add PlainTable extension (bundles Markdown, EditableTable, etc.) - Add PlainTableContentEditor.vue component - Expose window.OCA.Text.createTable() API in editor.js - Export PlainTable from extensions/index.js Signed-off-by: silver <s.szmajduch@posteo.de>
Signed-off-by: silver <s.szmajduch@posteo.de>
Signed-off-by: silver <s.szmajduch@posteo.de>
Signed-off-by: silver <s.szmajduch@posteo.de>
Signed-off-by: silver <s.szmajduch@posteo.de>
Signed-off-by: silver <s.szmajduch@posteo.de>
juliusknorr
force-pushed
the
add-table-node
branch
from
1a6b79a to
45deeac
Compare
Member
|
/backport to stable32 |
Member
|
/backport to stable31 |
Member
|
/backport to stable30 |
Member
|
/backport to stable29 |
This was referenced Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Add createTable() API to enable embedding markdown tables in other apps without rich text editing features. Introduces PlainTableDocument node that restricts content to tables only, and PlainTable extension that bundles required functionality (table editing, markdown serialization).
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)