fix(editor): rollback to the old vue2 provide hack#7628
Closed
max-nextcloud wants to merge 1 commit intomainfrom
Closed
fix(editor): rollback to the old vue2 provide hack#7628max-nextcloud wants to merge 1 commit intomainfrom
max-nextcloud wants to merge 1 commit intomainfrom
Conversation
4888c3e to
9305516
Compare
4 tasks
Calling `provide` in the setup function is still buggy in vue2. This led to the editor not being rendered in deck. Signed-off-by: Max <max@nextcloud.com>
9305516 to
e342497
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7628 +/- ##
==========================================
+ Coverage 52.96% 59.74% +6.78%
==========================================
Files 503 502 -1
Lines 43776 38853 -4923
Branches 1129 1128 -1
==========================================
+ Hits 23184 23211 +27
+ Misses 20483 15534 -4949
+ Partials 109 108 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
This patch applied at least displays the content again for me 👍 |
Contributor
|
@max-nextcloud I have made some tests. We can see the card description now, the smart picker works, but there are some js errors which break the editor menu bar. |
Collaborator
Author
|
@luka-nextcloud can you share the errors? |
Contributor
|
Collaborator
Author
|
Superseeded by #7643 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Calling
providein the setup function is still buggy in vue2.This led to the editor not being rendered in deck.