[stable31] fix(workspace): fix race condition when loading#7449
Merged
max-nextcloud merged 1 commit intostable31from Jul 14, 2025
Merged
[stable31] fix(workspace): fix race condition when loading#7449max-nextcloud merged 1 commit intostable31from
max-nextcloud merged 1 commit intostable31from
Conversation
`render` is called first. It awaits the import of `FilesHeaderRichWorkspaceView`. `updated` is called in the meantime. It failed during the if block as `FilesHeaderRichWorkspaceInstance` is not available yet. `render` continues with the folder it started with, which had no workspace. Signed-off-by: Max <max@nextcloud.com>
max-nextcloud
approved these changes
Jul 14, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stable31 #7449 +/- ##
=========================================
Coverage 58.46% 58.46%
=========================================
Files 289 289
Lines 36265 36266 +1
Branches 839 839
=========================================
+ Hits 21203 21204 +1
Misses 14943 14943
Partials 119 119 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
skjnldsv
approved these changes
Jul 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #7448