fix: Do not escape possible other editors syntax when serializing#7300
Draft
juliusknorr wants to merge 2 commits intomainfrom
Draft
fix: Do not escape possible other editors syntax when serializing#7300juliusknorr wants to merge 2 commits intomainfrom
juliusknorr wants to merge 2 commits intomainfrom
Conversation
Signed-off-by: Julius Knorr <jus@bitgrid.net>
642e6e8 to
80551ee
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7300 +/- ##
==========================================
+ Coverage 58.89% 59.08% +0.18%
==========================================
Files 289 482 +193
Lines 36816 37109 +293
Branches 853 1063 +210
==========================================
+ Hits 21682 21924 +242
- Misses 15032 15083 +51
Partials 102 102 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mejo-
reviewed
Nov 25, 2025
|
|
||
| const serializer = createMarkdownSerializer(tiptap.schema) | ||
| const md = serializer.serialize(tiptap.state.doc) | ||
| expect(md).toBe(source + ' editing') |
Member
There was a problem hiding this comment.
Suggested change
| expect(md).toBe(source + ' editing') | |
| expect(md).toBe(source + ' editing') | |
| tiptap.destroy() |
We had several test failures due to dangling editor instances in the past, so better to always explicitly destroy the editor in tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first attempt to resolve #4795 and #6864
Mostly just a hacky fix for now, i need to think a bit more about in which cases we may want to skip the escape and in which not
\[and\\[in the markdown source