Respect default extension setting in direct editing#7229
Conversation
max-nextcloud
left a comment
There was a problem hiding this comment.
Code looks good. Did you test it? Looks like it would be fairly easy to write a unit test for the TextDocumentCreator. Then we'd have some automated testing.
87a81e7 to
44520e8
Compare
Yes, I tested it. Just added unit test for it. |
juliusknorr
left a comment
There was a problem hiding this comment.
php-cs is unhappy and SPDX header is missing on the test file, but otherwise good to merge 👍
44520e8 to
dde1ab5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7229 +/- ##
=======================================
Coverage 52.18% 52.19%
=======================================
Files 479 479
Lines 41776 41774 -2
Branches 1025 1025
=======================================
Hits 21802 21802
+ Misses 19872 19870 -2
Partials 102 102 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
209eb11 to
8a2347a
Compare
Signed-off-by: Luka Trovic <luka@nextcloud.com>
8a2347a to
8ebe61f
Compare
|
/backport to stable30 |
|
/backport to stable31 |
📝 Summary
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)