fix(files): Place menubar at the bottom on mobile#6983
Merged
JuliaKirschenheuter merged 1 commit intomainfrom Mar 25, 2025
Merged
fix(files): Place menubar at the bottom on mobile#6983JuliaKirschenheuter merged 1 commit intomainfrom
JuliaKirschenheuter merged 1 commit intomainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6983 +/- ##
==========================================
+ Coverage 51.88% 58.85% +6.97%
==========================================
Files 478 477 -1
Lines 40579 35824 -4755
Branches 990 989 -1
==========================================
+ Hits 21054 21085 +31
+ Misses 19419 14634 -4785
+ Partials 106 105 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
marcoambrosini
left a comment
There was a problem hiding this comment.
Good design wise. I think we could probably omit the emoji picker since mobile keyboards always come with one
marcoambrosini
approved these changes
Mar 24, 2025
Member
marcoambrosini
left a comment
There was a problem hiding this comment.
^ that was non blocking so approving
Member
Good point, we should file that as a follow up. |
Member
|
Restarted cypress |
juliusknorr
reviewed
Mar 24, 2025
juliusknorr
approved these changes
Mar 24, 2025
566a1c7 to
1aa9964
Compare
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
1aa9964 to
8766c11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
🖼️ Screenshots
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)