fix(files): create suggestions bar#6856
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6856 +/- ##
==========================================
+ Coverage 51.86% 59.10% +7.23%
==========================================
Files 474 475 +1
Lines 40189 35620 -4569
Branches 988 987 -1
==========================================
+ Hits 20845 21054 +209
+ Misses 19240 14463 -4777
+ Partials 104 103 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a1dc138 to
ebc2d27
Compare
bc78ba4 to
bcbb1d0
Compare
|
/rebase |
|
@marcoambrosini could you please have a look into current state? Thank you! |
bcbb1d0 to
1c4e1c3
Compare
|
@JuliaKirschenheuter No need to commit the bundle js files in this repo, they get updated once merged. |
1c4e1c3 to
d8a7b03
Compare
ef05e27 to
7cf65de
Compare
7cf65de to
9bfba21
Compare
|
@marcoambrosini Can you have a look UI wise? The spacing between the first line and the suggesions looks a bit off to me @JuliaKirschenheuter Tested and functionality works as expected. Please check the remaining CI failures. |
7124483 to
2d7043d
Compare
|
Hi @marcoambrosini, could you please have a look? |
2d7043d to
d94f9ff
Compare
There was a problem hiding this comment.
A few points from my side:
1- The buttons group should be left aligned
2- This buttons flicker when opening a file that already have text
3- I think that the smart smart picker button should open the smart picker inline and not in the dialog
4- I think this buttons should be secondary
5- Possibly they should be directly below the first line, not hanging in the middle of the page
81fb273 to
a1e8e36
Compare
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
a1e8e36 to
a3a58e0
Compare
|
@JuliaKirschenheuter Best also leave a comment on what you have done, otherwise others cannot follow that As noted via chat 1,4,5 are addressed. One cypress runner had a temporary issue before starting cypress, restarted.
Would be fine as a follow up for me, but @JuliaKirschenheuter feel free to also push that here still. |
Thinking about this one a bit more again, it might be arguable if we want that button at all, as we have the plus button on the left doing the same. |
@marcoambrosini could i merge this PR and take points 2 and 3 (?) (it might be arguable if we want that button at all, as we have the plus button on the left doing the same) as follow-up? |

📝 Summary
🖼️ Screenshots
🏚️ Before
🏡 After