Skip to content

fix(outline): fix mobile detection and box shadow#6728

Merged
juliusknorr merged 1 commit intomainfrom
fix/outline_mobile
Dec 5, 2024
Merged

fix(outline): fix mobile detection and box shadow#6728
juliusknorr merged 1 commit intomainfrom
fix/outline_mobile

Conversation

@mejo-
Copy link
Member

@mejo- mejo- commented Dec 3, 2024

Also enable outline on mobile in read-write mode.

Fixes: #6410
Fixes: #6693

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits

Also enable outline on mobile in read-write mode.

Fixes: #6410
Fixes: #6693

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- added bug Something isn't working 3. to review labels Dec 3, 2024
@mejo- mejo- self-assigned this Dec 3, 2024
@mejo- mejo- requested a review from max-nextcloud as a code owner December 3, 2024 13:42
@mejo- mejo- requested a review from elzody December 3, 2024 13:43
@mejo-
Copy link
Member Author

mejo- commented Dec 3, 2024

/backport to stable30

@mejo-
Copy link
Member Author

mejo- commented Dec 3, 2024

/backport to stable29

Copy link
Contributor

@elzody elzody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it before and after on my end on mobile, looks much better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review bug Something isn't working

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Publicly shared .md files: Outline has no background on mobile Outline collides with text content on narrow viewports.

3 participants