[stable28] fix: Apply checks on shares in the middleware#6487
Merged
max-nextcloud merged 1 commit intostable28from Oct 2, 2024
Merged
[stable28] fix: Apply checks on shares in the middleware#6487max-nextcloud merged 1 commit intostable28from
max-nextcloud merged 1 commit intostable28from
Conversation
max-nextcloud
force-pushed
the
backport/6485/stable28
branch
from
3c98f2a to
78710d8
Compare
Member
|
Psalm is not happy :( |
max-nextcloud
force-pushed
the
backport/6485/stable28
branch
2 times, most recently
from
9adddea to
4672b24
Compare
Signed-off-by: Julius Härtl <jus@bitgrid.net> Signed-off-by: Max <max@nextcloud.com>
max-nextcloud
force-pushed
the
backport/6485/stable28
branch
from
4672b24 to
f207fda
Compare
max-nextcloud
approved these changes
Oct 2, 2024
Collaborator
max-nextcloud
left a comment
max-nextcloud
left a comment
There was a problem hiding this comment.
Had to replace some NC 29 syntax with the 28 equivalent.
But now psalm is happy and so am i.
provokateurin
approved these changes
Oct 2, 2024
2 tasks
Collaborator
|
/backport to stable27 |
Collaborator
|
/backport to stable26 |
Author
|
The backport to # Switch to the target branch and update it
git checkout stable26
git pull origin stable26
# Create the new backport branch
git checkout -b backport/6487/stable26
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick f207fda2
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/6487/stable26Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #6485
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.