fix: Reset session if file rename changes mimetype from/to markdown#6345
Merged
fix: Reset session if file rename changes mimetype from/to markdown#6345
Conversation
Member
Author
|
/backport to stable30 |
Member
Author
|
/backport to stable29 |
mejo-
force-pushed
the
fix/reset_session_rename
branch
2 times, most recently
from
44fc399 to
380d5b9
Compare
max-nextcloud
approved these changes
Sep 11, 2024
Collaborator
max-nextcloud
left a comment
max-nextcloud
left a comment
There was a problem hiding this comment.
Code changes look good after a review. Did not test it though.
Would it be possible to have an integration or e2e test for this?
For the event target file, we cannot use `getMimetype()` or `getExtension()` as it's a node of type `NonExistingFile`. Fixes: #5736 Signed-off-by: Jonas <jonas@freesources.org>
mejo-
force-pushed
the
fix/reset_session_rename
branch
from
380d5b9 to
3b7196f
Compare
Member
Author
Good point, I added e2e tests now. |
This was referenced Sep 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the event target file, we cannot use
getMimetype()orgetExtension()as it's a node of typeNonExistingFile.Fixes: #5736
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)