fix: Avoid throwing in BeforeNodeWrittenListener on new files#6167
Merged
juliusknorr merged 1 commit intomainfrom Aug 5, 2024
Merged
fix: Avoid throwing in BeforeNodeWrittenListener on new files#6167juliusknorr merged 1 commit intomainfrom
juliusknorr merged 1 commit intomainfrom
Conversation
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
fix/not-found-exception
branch
from
16fc94b to
f51001a
Compare
Member
Author
|
/backport to stable29 |
Member
Author
|
/backport to stable28 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found in sentry.
For new files we get a BeforeNodeWrittenEvent with a NonExistingFile object that might not have a file id yet. We should silently ignore this case. Debug logging added to still be able to trace this down if needed.