fix: Use css vars to adapt to new clickable area size#5990
Merged
juliusknorr merged 1 commit intomainfrom Jul 4, 2024
Merged
Conversation
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Member
Author
|
We'll likely catch some more UI issues, but this should be a good start to fix the out of place icons we currently have on main. |
juliusknorr
added
bug
Member
Author
|
Also this is now more in line with the office UI: 
|
marcoambrosini
approved these changes
Jul 4, 2024
Member
marcoambrosini
left a comment
marcoambrosini
left a comment
There was a problem hiding this comment.
Looks good @juliushaertl :)
If you link the vue lib master you likely spot more things coming up
mejo-
approved these changes
Jul 4, 2024
Member
mejo-
left a comment
mejo-
left a comment
There was a problem hiding this comment.
Thanks for starting to tackle this @juliushaertl <3
jancborchardt
approved these changes
Jul 4, 2024
Member
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
Looks good, and yep @juliushaertl that's why I said in the Office call that the toolbar there basically is already in our new style. :D
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We require some adjustments for nextcloud/server#45657
So far I've only reduced the different sizes so that the menubar is also just 34px in height.
Feedback would be welcome @marcoambrosini @jancborchardt