perf: Reduce polling interval for read only users#5930
Merged
juliusknorr merged 1 commit intomainfrom Jun 21, 2024
Merged
Conversation
mejo-
approved these changes
Jun 20, 2024
Member
mejo-
left a comment
mejo-
left a comment
There was a problem hiding this comment.
Code changes look sensible, I didn't test though.
How about creating an issue with some description how a proper implementation would look like and adding it to our board so we can tackle this soon and it doesn't get lost?
Member
Author
|
Definitely, will file an issue |
Member
Author
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
perf/read-only-sync
branch
from
b057d83 to
a3617e7
Compare
Member
Author
|
/backport to stable29 |
Member
Author
|
/backport to stable28 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce the polling interval for sync requests on read only sessions to 30s.
This is a quick fix, a proper way of doing that would be to actually add the read only state to the session data for each session joined. That way we could dynamically adjust the sync interval depending on if there are other users with editing permission in the document or not.
Especially useful if you have documents that have high viewing traffic as our app tutorials