perf(bootstrap): Lazy register template creator through event#5717
Merged
juliusknorr merged 1 commit intomainfrom May 6, 2024
Merged
perf(bootstrap): Lazy register template creator through event#5717juliusknorr merged 1 commit intomainfrom
juliusknorr merged 1 commit intomainfrom
Conversation
24 tasks
Collaborator
max-nextcloud
left a comment
max-nextcloud
left a comment
There was a problem hiding this comment.
Approach seems good - for what i understand. Linter and Static check still failing.
Comment on lines
5
to
7
| * @copyright Copyright (c) 2020 Morris Jobke <hey@morrisjobke.de> | ||
| * | ||
| * @author Morris Jobke <hey@morrisjobke.de> |
Collaborator
There was a problem hiding this comment.
Probably outdated, right?
We might also start using the SPDX headers right away when adding new files.
Member
Author
There was a problem hiding this comment.
Adjusted the copyright, but would rather keep moving to SPDX separate and do it with the migration script from Joas then for all files
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
perf/lazy-template-creator
branch
from
1891ab6 to
e0a2b99
Compare
|
Looks good, smart take on deferring the template creator setup until it is actually needed |
hweihwang
approved these changes
May 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires nextcloud/server#44952
This will avoid triggering dependency injection queries during app bootstrap for every request.