Skip to content

Comments

fix(css): Adjust heading sizes (Fixes: #5515)#5594

Merged
juliusknorr merged 1 commit intomainfrom
fix/heading_css
Apr 3, 2024
Merged

fix(css): Adjust heading sizes (Fixes: #5515)#5594
juliusknorr merged 1 commit intomainfrom
fix/heading_css

Conversation

@mejo-
Copy link
Member

@mejo- mejo- commented Apr 2, 2024

📝 Summary

Fixes: #5515

Also aligns with nextcloud/server#43640

🖼️ Screenshots

🏚️ Before 🏡 After
Screenshot 2024-04-02 at 16-25-54 headings md - Nextcloud Screenshot 2024-04-02 at 16-27-37 headings md - Nextcloud

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits

@mejo-
Copy link
Member Author

mejo- commented Apr 2, 2024

/backport to stable29

Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much nicer, thanks @mejo- 👍

Let's wait for @jancborchardt to double check

Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me!
Let's wait for designers :)

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well :)

@juliusknorr
Copy link
Member

@mejo- Mind to update the print screenshots used to compare in the CI?

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, much better :)

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- force-pushed the fix/heading_css branch from dcebcd1 to 81f07ce Compare April 3, 2024 12:03
@mejo-
Copy link
Member Author

mejo- commented Apr 3, 2024

@mejo- Mind to update the print screenshots used to compare in the CI?

Did now, thanks for the pointer 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CSS: reduce size differential between headings and text

5 participants