fix: Properly copy selection as markdown to the plaintext clipboard#5212
fix: Properly copy selection as markdown to the plaintext clipboard#5212max-nextcloud merged 1 commit intomainfrom
Conversation
Using clipboardTextSerializer we can copy the current selection as markdown and don't need the extra keyboard shortcut, which was broken anyways as it always selected the full text Signed-off-by: Julius Härtl <jus@bitgrid.net>
e3c445a to
ad26e8b
Compare
max-nextcloud
left a comment
There was a problem hiding this comment.
Have not tested it yet. Code changes look good. Nice to see more code getting removed than added. :)
I wonder what would happen with non-markdown files. I think the code in the editor factory might serve the purpose of extracting plaintext from the codeblock we currently wrap other files such as source code in.
max-nextcloud
left a comment
There was a problem hiding this comment.
Tested and works like a charm.
|
/backport to stable28 |
|
While this works this creates a lot of UX issues, as even if you just copy parts of code it always adds the code tags. Could we maybe somehow instead put both into the clipboard? |
Using clipboardTextSerializer we can copy the current selection as markdown and don't need the extra keyboard shortcut, which was broken anyways as it always selected the full text
Steps to reproduce:
Fix #5213