Fix cypress workspace test by setting default language#5143
Merged
juliusknorr merged 3 commits intomainfrom Dec 18, 2023
Merged
Fix cypress workspace test by setting default language#5143juliusknorr merged 3 commits intomainfrom
juliusknorr merged 3 commits intomainfrom
Conversation
Some tests modify it - so set it to `en` in `beforeEach`. Following the recommendataion of preparing everything in `beforeEach` hooks rather then reverting the changes in `after` hooks so the state of failing tests can be inspected. Signed-off-by: Max <max@nextcloud.com>
max-nextcloud
force-pushed
the
test/fix-cypress-workspace
branch
2 times, most recently
from
26706dc to
4a4e7e7
Compare
* `cy.openWorkspace()` and `cy.createDescription()` use the currently opened path now. They don't need any argument anymore. This also avoids duplicate page loads. * Use 'testFolder' alias and `this.testFolder` instead of `currentFolder` variable. Signed-off-by: Max <max@nextcloud.com>
max-nextcloud
force-pushed
the
test/fix-cypress-workspace
branch
from
fd8d55d to
f8a712a
Compare
Otherwise `this.testFolder` is not available as `this` cannot be reassigned with arrow functions. Signed-off-by: Max <max@nextcloud.com>
max-nextcloud
force-pushed
the
test/fix-cypress-workspace
branch
from
f8a712a to
7842447
Compare
juliusknorr
approved these changes
Dec 18, 2023
Collaborator
Author
|
/backport to stable28 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Some tests modify it - so set it to
eninbeforeEach.Following the recommendataion of preparing everything
in
beforeEachhooksrather then reverting the changes in
afterhooksso the state of failing tests can be inspected.
Includes a seperate commit to make use of
createTestFolderandvisitTestFoldercommands.🖼️ Screenshots of failure
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)