fix: Catch unique constraint violation when creating new documents#4289
Merged
juliusknorr merged 1 commit intomainfrom Jun 13, 2023
Merged
fix: Catch unique constraint violation when creating new documents#4289juliusknorr merged 1 commit intomainfrom
juliusknorr merged 1 commit intomainfrom
Conversation
Signed-off-by: Julius Härtl <jus@bitgrid.net>
3 flaky tests on run #10149 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Sync > recovers from a lost connection |
Output
Screenshots
|
|
nodes/HardBreak.spec.js • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Hard break support > Convert paragraph break into hard break |
Output
Screenshots
|
|
api/UsersApi.spec.js • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| The user mention API > fetches users with valid session |
Output
Screenshots
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
blizzz
approved these changes
Jun 13, 2023
Member
Author
|
/backport to stable27 |
Member
Author
|
/backport to stable26 |
Member
Author
|
/backport to stable25 |
This was referenced Jun 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There might be cases where multiple requests try to create a new document entry where the previous query to get the document returned none but at the time of insert another request already inserted.
This is a care we should handle more gracefully and instead query the db again and return the document entity.
📝 Summary
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)