fix(UserApiController): Fix warning during test run with PHP 8.2#4241
Merged
juliusknorr merged 2 commits intomainfrom Jun 6, 2023
Merged
fix(UserApiController): Fix warning during test run with PHP 8.2#4241juliusknorr merged 2 commits intomainfrom
juliusknorr merged 2 commits intomainfrom
Conversation
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
This was referenced Jun 6, 2023
max-nextcloud
approved these changes
Jun 6, 2023
Collaborator
|
Cypress failures cannot be related - but I wonder where the block merges during freezes is coming from... And i wonder why i could still merge this. |
Member
Author
Member
Author
|
Cypress failure looks a bit like it could be a upstream issue with loading the files app: |
Member
Author
|
Pushed a fix for the merge block #4243 |
Member
Author
|
/backport to stable27 |
Member
Author
|
/backport to stable26 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fix test failure that only happens on PHP8.2