fix: update ImageView

[luka-nextcloud]

📝 Summary

• Resolves: Editing image description fails if enter isn't pressed #4045

🖼️ Screenshots

🏚️ Before	🏡 After
B	A

🚧 TODO

• ...

🏁 Checklist

• Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
• Sign-off message is added to all commits
• Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
• Documentation (README or documentation) has been updated or is not required

[cypress]

1 flaky tests on run #9512 ↗︎

0

142

1

0

1

Details:

fix: update ImageView
Project: Text	Commit: 84788d5ccc
Status: Passed	Duration: 04:23 💡
Started: Apr 26, 2023 1:20 PM	Ended: Apr 26, 2023 1:24 PM

  cypress/e2e/conflict.spec.js • 1 flaky test

View Output Video

Test		Artifacts
Open test.md in viewer > resolves conflict using current editing session		Output Screenshots

_{This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.}

[max-nextcloud]

I wonder why @blur did not do the trick. But this also seems fine.

[juliusknorr]

The @blur seems to work just fine, however I noticed that the actual issue seems to be that the component might be re-rendered if the user moves the mouse out which then restores the old value even before the blur was triggered

text/src/nodes/ImageView.vue

Line 32 in 5730fc7

@mouseover="showIcons = true"

Anyways I think always updating seems more safe to me 👍

[juliusknorr]

/compile amend /

[max-nextcloud]

shall we backport this?

[juliusknorr]

/compile amend /

[juliusknorr]

/backport to stable26

[juliusknorr]

/backport to stable25

[backportbot-nextcloud]

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin/stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

[backportbot-nextcloud]

The backport to stable25 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable25
git pull origin/stable25

# Create the new backport branch
git checkout -b fix/foo-stable25

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

[juliusknorr]

@luka-nextcloud Please backport manually.