chore(deps): update dependency eslint-plugin-cypress to ^2.13.3 (stable26)#4017
Merged
max-nextcloud merged 5 commits intostable26from May 3, 2023
Merged
Conversation
4 flaky tests on run #9584 ↗︎Details:
|
||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Workspace > callouts > create callout |
Output
Screenshots
|
|
| Workspace > callouts > toggle callouts |
Output
Screenshots
|
|
sync.spec.js • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Sync > recovers from a lost connection |
Output
Screenshots
|
|
share.spec.js • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Open test.md in viewer > Share a file with download disabled shows an error |
Output
Screenshots
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
Member
|
Lots of those: |
juliusknorr
previously requested changes
Apr 13, 2023
Member
juliusknorr
left a comment
There was a problem hiding this comment.
Needs some adjustments on the cypress tests:
https://docs.cypress.io/guides/core-concepts/retry-ability#Actions-should-be-at-the-end-of-chains-not-the-middle
cypress-io/cypress#26026
8504b97 to
6fe0dff
Compare
Collaborator
|
/compile |
bded6de to
d457935
Compare
juliusknorr
approved these changes
May 2, 2023
d457935 to
5e0d152
Compare
Makes the current eslint plugin pass. Signed-off-by: Max <max@nextcloud.com>
Remove unnecessary `cy.getSubmenuEntry` as it will open the parent menu. This is a leftover from e9f54d0. Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Contributor
Author
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
Collaborator
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^2.12.1->^2.13.3Release Notes
cypress-io/eslint-plugin-cypress
v2.13.3Compare Source
Bug Fixes
no-unnecessary-waitingrule (c626ad5)v2.13.2Compare Source
Bug Fixes
v2.13.1Compare Source
Bug Fixes
v2.13.0Compare Source
Features
Configuration
📅 Schedule: Branch creation - "before 5am every weekday,every weekend" in timezone Europe/Berlin, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.