[stable25] Only open direct link files if link points to Files app#3905
Merged
juliusknorr merged 1 commit intostable25from Mar 6, 2023
Merged
[stable25] Only open direct link files if link points to Files app#3905juliusknorr merged 1 commit intostable25from
juliusknorr merged 1 commit intostable25from
Conversation
mejo-
changed the title
4 tasks
1 flaky tests on run #8926 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| test link marks > link preview > shows a link preview |
Output
Screenshots
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
Member
|
/compile amend / |
Until now, we always opened direct link files when a link contained a `fileId` query parameter. This breaks e.g. links to pages from the Collectives app, which contain `fileId` parameters as well. Limit opening direct file link to links that point to the Files app. Fixes: #3857 Signed-off-by: Jonas <jonas@freesources.org> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
backport/3870/stable25
branch
from
8bb73ed to
f54c1e8
Compare
juliusknorr
approved these changes
Mar 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport of #3870
Until now, we always opened direct link files when a link contained a
fileIdquery parameter. This breaks e.g. links to pages from the Collectives app, which containfileIdparameters as well.Limit opening direct file link to links that point to the Files app.
Fixes: #3857