chore(import): Avoid importing NcModal through other export#3735
Merged
juliusknorr merged 1 commit intomainfrom Feb 9, 2023
Merged
chore(import): Avoid importing NcModal through other export#3735juliusknorr merged 1 commit intomainfrom
juliusknorr merged 1 commit intomainfrom
Conversation
Passing run #8569 ↗︎Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
Member
Author
560228e to
3fe414a
Compare
3fe414a to
44b0519
Compare
luka-nextcloud
approved these changes
Feb 7, 2023
Member
Author
|
/rebase |
44b0519 to
728ab51
Compare
Member
Author
|
/rebase |
728ab51 to
2c31138
Compare
Member
Author
|
/compile amend / |
Signed-off-by: Julius Härtl <jus@bitgrid.net> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2c31138 to
dd98981
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Otherwise we ship the Modal component twice in the bundles.