Fix escaping of | inside table cells#3112
Merged
vinicius73 merged 3 commits intomasterfrom Oct 3, 2022
Merged
Conversation
susnux
added
bug
Member
|
Works! Can you prepare a test for it? To prevent eventual regression. |
juliusknorr
approved these changes
Oct 2, 2022
Member
juliusknorr
left a comment
juliusknorr
left a comment
There was a problem hiding this comment.
Thanks a tons, tested and works. 👍
A small unit test would be great :)
`|` is a special character inside tables and need to be escaped if used inside table cells. Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
susnux
force-pushed
the
fix/table-escape
branch
from
fe1b985 to
61df5f4
Compare
Contributor
Author
|
/compile |
Contributor
Author
|
@vinicius73 @juliushaertl Added a test to ensure table cells are escaped |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Member
|
/backport 9b3ddae,61df5f4fbdbb2962d15f34bb0b74af046646c324 to stable25 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
|is a special character inside tables and need to be escaped if used inside table cells.Without this tables get broken if a cell contains something like
a | b.