Remove focus-visible outline from headings#2922
Merged
juliusknorr merged 2 commits intomasterfrom Sep 20, 2022
Merged
Conversation
vinicius73
approved these changes
Sep 15, 2022
c768ffc to
a4e89e3
Compare
Contributor
Author
|
/compile |
juliusknorr
approved these changes
Sep 20, 2022
This was introduced by using NodeViews. Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
cdfe888 to
095ed5f
Compare
This was referenced Sep 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The focus-visible outline was unintentionally introduced by using a NodeView, but the outline is quite distracting when editing text.
This fixes #2921 by simply removing the outline, but if the outline is now considered to stay, it could be fixed by changing the added rule to look like this:
Currently with outline:

With this change and similar to NC24:
