Able to show outiline in readonly mode

[vinicius73]

• Resolves: Table of contents: add button to close outline from itself #2904
• Target version: master

Readonly

Peek.2022-09-14.18-03.mp4

Public

Peek.2022-09-14.17-01.mp4

[max-nextcloud]

Code looks good.

However if i click an entry in the outline it does not move to that heading. That's not what i'd expect because the entry is highlighted and looks like a link to me.

I also managed to trigger some funny behavior when clicking at the end of headings. I was not able to produce the same behavior on the editable view of the owner of the file.
Bildschirmaufzeichnung vom 15.09.2022, 08:19:51.webm

[jancborchardt]

Nice! Another point in addition to @susnux:
The "x" close button is a bit floating in the air. Would be better if it’s directly after the "Outline" text instead of floating on the right.

[mejo-]

Thanks a lot for looking into this @vinicius73 ❤️

Unfortunately using the menubar space in read-only mode conflicts with Collectives, where we already use this space for Collectives-specific content (last changed user and timestamp, in future also things like count of backlinks and attachments). Sorry, I don't have a quick solution for this. Maybe we should discuss it in our next team call?

[vinicius73]

Thanks a lot for looking into this @vinicius73 ❤️

Unfortunately using the menubar space in read-only mode conflicts with Collectives, where we already use this space for Collectives-specific content (last changed user and timestamp, in future also things like count of backlinks and attachments). Sorry, I don't have a quick solution for this. Maybe we should discuss it in our next team call?

What do you think about make able to inject a slot that space and expose some editor methods?

So that way you will be able to not only inject more options also access internal editor methods in a safe way

[vinicius73]

@jancborchardt what do you think about this?

[mejo-]

What do you think about make able to inject a slot that space and expose some editor methods?

So that way you will be able to not only inject more options also access internal editor methods in a safe way

That would be the way to go indeed 😊

[jancborchardt]

@vinicius73 it's better if the x is on the right if the text, so that the text is left-aligned with the headings below. :) Just not all the way over away from the text.

[juliusknorr]

/backport to stable25

[blizzz]

master is 26

[mejo-]

@vinicius73 could you take a quick look into rebasing the PR on latest master? Seems like something went wrong and unrelated commits got pulled in 😉

[vinicius73]

@mejo- I've rewritten the all PR, check if you can please

[mejo-]

Nice, thanks a lot @vinicius73. Works like expected. I removed the top: 104px as discussed here. It doesn't solve the problem for Collectives yet, but at least it doesn't break Collectives any longer - and it adds outline support for read-only Text shares, which is great 😍

[mejo-]

/compile

[backportbot-nextcloud]

The backport to stable25 failed. Please do this backport manually.

[mejo-]

/backport 103d8ef,7d9a18b15c56608fa38492ec9d7f877130922488 to stable25