Conversation
Also added a chai assertion for checking an element is currently shown in the viewport of the window. This is needed as the cypress visibility checks fail for tiptap elements, as they are overlaid by the author color / names. Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
Handle inter-page links properly and use a heading view for displaying links and link anchors. Implements #2173 Also fix link handling, to scroll to selected header when clicking on an anchor link (`#some-id`). Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
vinicius73
approved these changes
Sep 13, 2022
Member
vinicius73
left a comment
vinicius73
left a comment
There was a problem hiding this comment.
Thanks for take care of this.
Member
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bring back the link anchors for headings. Also added tests for the issue where changing the heading level removed the heading content (#2868)