Merged
Conversation
vinicius73
requested review from
julien-nc,
luka-nextcloud,
max-nextcloud and
mejo-
vinicius73
force-pushed
the
update/nextcloud-vue-7-beta-2
branch
from
0fe0ed8 to
15636f4
Compare
julien-nc
reviewed
Sep 12, 2022
Member
julien-nc
left a comment
julien-nc
left a comment
There was a problem hiding this comment.
Seems all good.. Clicked around the interface and no issue found.
Tests are not passing locally though. In share.spec.js:
Timed out retrying after 4000ms: Expected to find element: #viewer[data-handler="text"], but never found it.
Member
Author
|
/rebase |
nextcloud-command
force-pushed
the
update/nextcloud-vue-7-beta-2
branch
from
15636f4 to
6a0b72c
Compare
Collaborator
|
/rebase |
nextcloud-command
force-pushed
the
update/nextcloud-vue-7-beta-2
branch
from
6a0b72c to
1ece76a
Compare
Collaborator
|
/compile |
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
max-nextcloud
force-pushed
the
update/nextcloud-vue-7-beta-2
branch
from
9f7c5fa to
cb4f236
Compare
Collaborator
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Collaborator
Passed twice for me. I'll approve and we can investigate the failing test later. |
max-nextcloud
approved these changes
Sep 13, 2022
Collaborator
max-nextcloud
left a comment
max-nextcloud
left a comment
There was a problem hiding this comment.
thanks heaps for looking into this!
This was referenced Sep 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.