Add printing style sheet, enables printing of text files#2867
Merged
vinicius73 merged 3 commits intomasterfrom Sep 13, 2022
Merged
Add printing style sheet, enables printing of text files#2867vinicius73 merged 3 commits intomasterfrom
vinicius73 merged 3 commits intomasterfrom
Conversation
susnux
added
enhancement
susnux
force-pushed
the
feat/print_css
branch
from
0508a2d to
360a7a1
Compare
vinicius73
reviewed
Sep 6, 2022
susnux
force-pushed
the
feat/print_css
branch
3 times, most recently
from
0eddead to
cd0a041
Compare
Contributor
Author
|
I had to add the rule for hiding the content behind the modal as an event listener to prevent hiding the content if the editor was loaded for rich workspace. |
susnux
force-pushed
the
feat/print_css
branch
from
cd0a041 to
c0e0a04
Compare
vinicius73
force-pushed
the
feat/print_css
branch
from
c0e0a04 to
95da217
Compare
Member
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
Currently printing will include the menu bar and longer text files will be cropped after the first page. This enables printing of text documents without any major styling changes, slightly adjusted margins and added table borders. This implements the CSS part of #112 Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
susnux
force-pushed
the
feat/print_css
branch
from
95da217 to
1c88045
Compare
Contributor
Author
No, this happened because the |
vinicius73
approved these changes
Sep 12, 2022
Member
vinicius73
left a comment
vinicius73
left a comment
There was a problem hiding this comment.
Looks awesome.
Peek.2022-09-12.20-36.mp4
Member
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently printing will include the menu bar and longer text files will be cropped after the first page.
This enables printing of text documents without any major styling changes,
slightly adjusted margins and added table borders (they are quite hard to read without on paper).
This implements the CSS part of #112