Fix emoji autocompletion keyboard behaviour#2863
Merged
max-nextcloud merged 4 commits intomasterfrom Sep 13, 2022
Merged
Conversation
mejo-
force-pushed
the
fix/emoji_list_keys
branch
from
85b42db to
de94136
Compare
Member
Author
|
/compile |
mejo-
force-pushed
the
fix/emoji_list_keys
branch
from
de94136 to
3b6fe5b
Compare
Member
Author
|
/compile |
Member
Author
This needs to be tackled seperately, we have #2199 to track it. |
Member
Author
|
/backport to stable24 |
mejo-
force-pushed
the
fix/emoji_list_keys
branch
from
33b2163 to
7ea81cc
Compare
Member
Author
|
/compile |
Member
Author
|
/rebase |
nextcloud-command
force-pushed
the
fix/emoji_list_keys
branch
from
b974839 to
b62e6ae
Compare
Member
Author
|
/rebase |
mejo-
force-pushed
the
fix/emoji_list_keys
branch
from
b62e6ae to
fd543d8
Compare
Member
Author
|
/compile |
1 similar comment
Member
Author
|
/compile |
Member
Author
|
/rebase |
Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
mejo-
force-pushed
the
fix/emoji_list_keys
branch
from
e828d86 to
013f725
Compare
Collaborator
|
/compile amend / |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
fix/emoji_list_keys
branch
from
013f725 to
1f2503e
Compare
max-nextcloud
approved these changes
Sep 13, 2022
Collaborator
max-nextcloud
left a comment
max-nextcloud
left a comment
There was a problem hiding this comment.
Code looks good. I'll try it and then merge.
|
The backport to stable24 failed. Please do this backport manually. |
Member
Author
|
/backport 1bcf041,f090c52317aebfdc36a6d965d2307fdf100139ee,6eb324f144b3761fc153dacc75b14e3e9b35d0cf to stable24 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When emoji picker is open, Esc should only close emoji picker, not the full editor modal(This needs to be tackled seperately, we have Escape key should not close the editor #2199 to track it.)Resolves: #2785