Conversation
vinicius73
left a comment
There was a problem hiding this comment.
I've sent some comments.
Please, check the ESLint warnings
8845929 to
9e10b51
Compare
Signed-off-by: Luka Trovic <luka@nextcloud.com>
9e10b51 to
a81c8c3
Compare
|
@juliushaertl I've uploaded a video to show the status. |
|
@luka-nextcloud I think we agreed on trying to use portal-vue as a way to not re-implement the header bar, but instead try to only inject the menubar parts into the existing header. If there have been any obstacles, maybe you can provide a summary of what you tried and why this didn't work. This would be a flexible way to also take the mockups into account which are different for the logged in users where the viewer is used with the white header bar and the public share links that use the blue existing bar. We should try to avoid reimplementing the parts that are already in there by default like the close button/actions/download button. |
|
@luka-nextcloud Let me close this for now as it is on hold and needs a different approach anyways as we talked about the possible usage of vue-portal. |
Signed-off-by: Luka Trovic luka@nextcloud.com
Summary
unified-header-update.mov