Do not register text/csv mimetype when office can handle it#2448
Merged
juliusknorr merged 1 commit intomasterfrom May 25, 2022
Merged
Do not register text/csv mimetype when office can handle it#2448juliusknorr merged 1 commit intomasterfrom
juliusknorr merged 1 commit intomasterfrom
Conversation
max-nextcloud
approved these changes
May 25, 2022
Collaborator
max-nextcloud
left a comment
max-nextcloud
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks for tackling this.
vinicius73
approved these changes
May 25, 2022
Member
Author
|
/compile amend / |
Signed-off-by: Julius Härtl <jus@bitgrid.net> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
bugfix/csv
branch
from
37fe0f5 to
d9931d0
Compare
Member
Author
|
/backport to stable24 |
Member
Author
|
/backport to stable23 |
Member
Author
|
/backport to stable22 |
|
The backport to stable22 failed. Please do this backport manually. |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure to only register CSV handling for the viewer when there are no other options as Collabora and ONLYOFFICE have better capabilities for showing and editing those.
We could have this as an optional file opener through the 3 dots menu, but the viewer currently does not support that and only allows registering for the default file action.