Allow linking to directories in addition to linking to files.#2166
Allow linking to directories in addition to linking to files.#2166rotdrop wants to merge 1 commit intonextcloud:masterfrom
Conversation
The link syntax supported is: [LINK_TEXT_AS_NORMAL](RELATIVE/PATH/WITH/TRAILING/SLASH/?fileId=FILE_ID_OF_DIRECTORY) In the current implementation clicking on the link leads to a new tab or window where the linked directory is shown. The difference to the syntax for ordinary files is just the missing file-name at the end. Signed-off-by: Claus-Justus Heine <himself@claus-justus-heine.de>
3e7ae96 to
2bdc813
Compare
|
Thanks for your pull request. Looks sane code wise, but haven't tested yet. Since we had merged the tiptap v2 upgrade in the meantime could you maybe rebase your changes on top of latest master? |
I'll have a look, but not before mid of next week. Thanks for looking into my PR. |
|
I've tried to rebase the master branch into your code @rotdrop, but the source code changed a lot. Link folders and other files from internal storage still look like a good feature to have, we have to start it again. We will probably bring back the 'add file link' feature soon and we will ping you and point you in the right direction to implement your feature. |
Well not quite, at least with NC 24. With the menu bubble linking to cloud-files is still possible, without any changes. I can eventually open another merge request. And yes: some things have really changed a lot, and adding this to the main-menu seems no longer to be easy. Still, it works with the "menu-bubble".
|
The link syntax supported is:
In the current implementation clicking on the link leads to a new tab or
window where the linked directory is shown.
The difference to the syntax for ordinary files is just the missing
file-name at the end.
Summary