Merged
Conversation
See nextcloud#787. An EPUB is a zip archive, so opening it for editing as plaintext is unexpected behavior and risks corrupting the file.
juliusknorr
approved these changes
Jan 26, 2021
Member
|
/backport to stable20 |
Member
|
/backport to stable19 |
This was referenced Jan 26, 2021
Contributor
Author
|
Hi @juliushaertl , I think the bundles weren't rebuilt in the most recent 20.x releases, so this bug is still occurring in 20.0.7 and 20.0.8. Another user recently reported the same behavior in nextcloud/server#25921. When I build the app myself, clicking an epub file initiates a download as expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
An EPUB is a zip archive, so opening it for editing as plaintext is unexpected behavior and risks corrupting the file.