Fix parameter passed to OC.Notification#1989
Merged
nickvergessen merged 2 commits intomasterfrom Jul 15, 2019
Merged
Conversation
"OC.Notification.showTemporary" expects a string as its first parameter (even if it contains HTML markup), but a jQuery object was passed instead; until now this just happened to work due to the internal implementation of that method, but this no longer works since the switch to Toastify in Nextcloud 17. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
nickvergessen
force-pushed
the
fix-parameter-passed-to-oc-notification
branch
from
af24a4c to
6e9a8ca
Compare
nickvergessen
approved these changes
Jul 15, 2019
Member
|
Should we wait for the server PR with the merge? |
Member
merged now |
delete-merged-branch
bot
deleted the
fix-parameter-passed-to-oc-notification
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires nextcloud/server#16369
OC.Notification.showTemporaryexpects a string as its first parameter (even if it contains HTML markup), but a jQuery object was passed instead; until now this just happened to work due to the internal implementation of that method, but this no longer works since the switch to Toastify in Nextcloud 17.How to test
Result with this pull request
The notification shows Screensharing extension is required to share your screen.; clicking on it opens the extension page.
Result without this pull request
The notification shows [Object object].