feat(users): add disabled users to storage stats#837
Conversation
f3795f0 to
5bcf3aa
Compare
come-nc
left a comment
There was a problem hiding this comment.
You should rely on IUserManager::countDisabledUsers() instead of querying the DB
|
Oops, forgot about this one. I'll might as well change |
5bcf3aa to
4b9ef61
Compare
4b9ef61 to
ed01f81
Compare
And get the total number of users directly from IUserManager Signed-off-by: Thomas Citharel <tcit@tcit.fr>
ed01f81 to
744d70a
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Also add a condition on the
lastLoginquery for total number of users, just in case there's another app that uses this specific key