Merged
Conversation
R0Wi
force-pushed
the
feature/list-php-extensions
branch
from
19d4b3e to
7baa682
Compare
R0Wi
force-pushed
the
feature/list-php-extensions
branch
from
7baa682 to
883b825
Compare
Member
Author
|
Sorry did some mistake, |
CarlSchwan
reviewed
Jan 21, 2022
come-nc
approved these changes
Apr 1, 2022
tcitworld
reviewed
Apr 1, 2022
| * @return string as csv list of loaded extensions | ||
| */ | ||
| protected function getLoadedPhpExtensions(): string { | ||
| $extensions = (function_exists('get_loaded_extensions') ? get_loaded_extensions() : ['Unable to list extensions']); |
Member
There was a problem hiding this comment.
getLoadedPhpExtensions should probably return the list of extensions directly and fallback to null if the function doesn't exist, and we would do the implode part inside the template.
This would allow this function to be reusable elsewhere and the 'Unable to list extensions' message being translatable without injecting I10N into this class.
Member
Author
There was a problem hiding this comment.
Sounds cleaner to me, too. Shall i implement this task as separate PR? Or anyone else interested?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In many situations it's good to know which php extensions are enabled in the current setup. Usually one would look this up in
phpinfopage but this one is not included in NC, so i thought it would be nice to add this info to the serverinfo page?