Accessibility ♿

[skjnldsv]

Fixes #1692
Requires #9723

themes

fonts

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@ab266a7). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master    #9862   +/-   ##
=========================================
  Coverage          ?   51.97%           
  Complexity        ?    26017           
=========================================
  Files             ?     1660           
  Lines             ?    96167           
  Branches          ?     1290           
=========================================
  Hits              ?    49982           
  Misses            ?    46185           
  Partials          ?        0

Impacted Files	Coverage Δ	Complexity Δ
apps/accessibility/lib/AccessibilityProvider.php	0% <0%> (ø)	3 <3> (?)
...pps/accessibility/lib/Settings/PersonalSection.php	0% <0%> (ø)	5 <5> (?)
apps/accessibility/appinfo/routes.php	0% <0%> (ø)	0 <0> (?)
apps/accessibility/templates/settings-personal.php	0% <0%> (ø)	0 <0> (?)
apps/accessibility/lib/Settings/Personal.php	0% <0%> (ø)	4 <4> (?)
apps/accessibility/appinfo/app.php	0% <0%> (ø)	0 <0> (?)
.../accessibility/lib/Controller/ConfigController.php	0% <0%> (ø)	8 <8> (?)
apps/accessibility/lib/AppInfo/Application.php	0% <0%> (ø)	4 <4> (?)
...ibility/lib/Controller/AccessibilityController.php	0% <0%> (ø)	9 <9> (?)

[MorrisJobke]

Analysing /drone/src/github.com/nextcloud/server/apps/accessibility/lib/Controller/AccessibilityController.php
line 95: OC_App - Static method of private class must not be called
App is not compliant

[MorrisJobke]

Tests look good - only this one is failing:

  Scenario: create folder in a public editable shared folder        # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files.feature:64
    Given I act as John                                             # ActorContext::iActAs()
    And I am logged in                                              # LoginPageContext::iAmLoggedIn()
    And I create a new folder named "Editable shared folder"        # FileListContext::iCreateANewFolderNamed()
    And I close the details view                                    # FilesAppContext::iCloseTheDetailsView()
      │ Close current section details view in Files app could not be clicked
      │ Exception message: Offset within element cannot be scrolled into view: (0, 0): http://acceptance-app-files/index.php/apps/files/?dir=/&fileid=32#
      │ Build info: version: '2.53.1', revision: 'a36b8b1', time: '2016-06-30 17:37:03'
      │ System info: host: '49293c4fe7c5', ip: '172.17.0.20', os.name: 'Linux', os.arch: 'amd64', os.version: '4.15.0-22-generic', java.version: '1.8.0_91'
      │ Driver info: driver.version: unknown
      │ Trying again
      │ 
      Element not found with xpath, (((//html//*[starts-with(@id, 'app-content-')  and not(contains(concat(' ', normalize-space(@class), ' '), ' hidden '))])[1]/preceding-sibling::*[position() = 1 and @id = 'app-sidebar'])[1]/descendant-or-self::*[@class and contains(concat(' ', normalize-space(@class), ' '), ' icon-close ')])[1]
      
      Unable to locate element: {"method":"xpath","selector":"(((//html//*[starts-with(@id, 'app-content-')  and not(contains(concat(' ', normalize-space(@class), ' '), ' hidden '))])[1]/preceding-sibling::*[position() = 1 and @id = 'app-sidebar'])[1]/descendant-or-self::*[@class and contains(concat(' ', normalize-space(@class), ' '), ' icon-close ')])[1]"}
      For documentation on this error, please visit: http://seleniumhq.org/exceptions/no_such_element.html
      Build info: version: '2.53.1', revision: 'a36b8b1', time: '2016-06-30 17:37:03'
      System info: host: '49293c4fe7c5', ip: '172.17.0.20', os.name: 'Linux', os.arch: 'amd64', os.version: '4.15.0-22-generic', java.version: '1.8.0_91'
      Driver info: driver.version: unknown (WebDriver\Exception\NoSuchElement)
    And I see that the details view is closed                       # FilesAppContext::iSeeThatTheDetailsViewIsClosed()
    And I share the link for "Editable shared folder"               # FilesAppContext::iShareTheLinkFor()
    And I set the shared link as editable                           # FilesAppContext::iSetTheSharedLinkAsEditable()
    And I write down the shared link                                # FilesAppContext::iWriteDownTheSharedLink()
    When I act as Jane                                              # ActorContext::iActAs()
    And I visit the shared link I wrote down                        # FilesSharingAppContext::iVisitTheSharedLinkIWroteDown()
    And I see that the current page is the shared link I wrote down # FilesSharingAppContext::iSeeThatTheCurrentPageIsTheSharedLinkIWroteDown()
    And I create a new folder named "Subfolder"                     # FileListContext::iCreateANewFolderNamed()
    Then I see that the file list contains a file named "Subfolder" # FileListContext::iSeeThatTheFileListContainsAFileNamed()

Looks like a temporal hiccup, right @danxuliu?

[skjnldsv]

@MorrisJobke Yes, timeout issue by the tests.
Unrelated

[jancborchardt]

Really great stuff!

Another thing we should probably do when accessibility is enabled, to move the fonts from Light+Semibold (300+600) to Regular+Bold (400+700).

Also, the buttons for the avatar change look very dark? The contrast with the icon is not enough. We should only make the border darker, like with the inputs.

[skjnldsv]

Another thing we should probably do when accessibility is enabled, to move the fonts from Light+Semibold (300+600) to Regular+Bold (400+700).

Really nice idea!
The dyslexia font is set like this already btw :)

Also, the buttons for the avatar change look very dark? The contrast with the icon is not enough. We should only make the border darker, like with the inputs.

Yes, I increased the opacity to the max for the highcontrast theme and removed the slight variations we have on the background. Basically, I only allowed 2 tones: background and slightly darker background and the font foreground.

[jancborchardt]

Also cc @nextcloud/accessibility @nextcloud/designers for review :)

[skjnldsv]

@jancborchardt not ready for review :)
Soon though ;)

[skjnldsv]

Okay now! :)

[jancborchardt]

So, everyone in @nextcloud/accessibility @nextcloud/designers – any review is welcome! :)

[juliusknorr]

That doesn't work when index.php is present in the URL:

[juliusknorr]

(It should be /index.php/apps/accessibility... )

[skjnldsv]

@juliushaertl hum, tricky!

[juliusknorr]

Maybe that will help:

server/apps/theming/appinfo/app.php

Lines 35 to 47 in 0eebff1

	$linkToCSS = \OC::$server->getURLGenerator()->linkToRoute(
	'theming.Theming.getStylesheet',
	[
	'v' => \OC::$server->getConfig()->getAppValue('theming', 'cachebuster', '0'),
	]
	);
	\OCP\Util::addHeader(
	'link',
	[
	'rel' => 'stylesheet',
	'href' => $linkToCSS,
	]
	);

[skjnldsv]

But you cannot prepend with addHeader :/

[skjnldsv]

Well, apparently it works without the prepend now.

[MariusBluem]

Why do we want to have this enabled by default and shipped with the core-server?

Love the contrast-mode :)

[skjnldsv]

Okay, so let get this merge then! :)
@nextcloud/designers @rullzer

[MorrisJobke]

I like it 👍 Lets get it in and ask for some feedback

[rullzer]

+1 lets do this and iterate later.