Background job to clean up old backups of the updater

[MorrisJobke]

• a one-time job gets scheduled after each update via a repair job
• the job remove all directories inside data/updater-INSTANCEID/backups except the 3 most recent ones (determined by mtime of the folder)

The backup dir on my instance looks like this summing up for nearly 8 GB 🙈):

nextcloud-11.0.0.10
nextcloud-11.0.0.2
nextcloud-11.0.0.4
nextcloud-11.0.0.5
nextcloud-11.0.0.6
nextcloud-11.0.0.9
nextcloud-11.0.2.7
nextcloud-11.0.3.2
nextcloud-12.0.0.20
nextcloud-12.0.0.21
nextcloud-12.0.0.24
nextcloud-12.0.0.26
nextcloud-12.0.1.0
nextcloud-12.0.1.1
nextcloud-12.0.1.3
nextcloud-12.0.1.5
nextcloud-12.0.2.0
nextcloud-12.0.3.1
nextcloud-12.0.3.2
nextcloud-12.0.4.0
nextcloud-12.0.4.1
nextcloud-12.0.4.2
nextcloud-12.0.4.3
nextcloud-13.0.0.10
nextcloud-13.0.0.11
nextcloud-13.0.0.13
nextcloud-13.0.0.14
nextcloud-13.0.0.7
nextcloud-13.0.0.8
nextcloud-13.0.0.9
nextcloud-13.0.1.0
nextcloud-13.0.1.1
nextcloud-13.0.2.0
nextcloud-13.0.2.1
nextcloud-13.0.3.0
nextcloud-13.0.3.1
nextcloud-13.0.3.2
nextcloud-9.1.0.16
nextcloud-9.1.1.1
nextcloud-9.1.1.2
nextcloud-9.1.1.4
nextcloud-9.1.1.5

[rullzer]

yep makes a lot of sense!

[rullzer]

strict?

[MorrisJobke]

Didn't want to do it, because it uses a abstract class and I don't want to mess right now :/

[rullzer]

okidoki!

[rullzer]

Failing test is a temp hiccup

[GutHib]

I am here because there are six previous versions of nextcloud in my backups folder, and I was looking for a way to get rid of them automatically. If the one-time job is supposed to delete all directories except for the past three, and I already have six, is it reasonable to assume that the feature may not be working like it should?

Also, is there any chance you might add an option so everyone could decide individually how many previous versions they would like to keep? 1.1 gigs for three unused folders may not seem like much on a huge disk, but if you host on a small VPN these things do add up (and since rollbacks aren't possible anyway, I personally don't see why I should keep more than one previous version).

Thanks!

[omocinteractive]

It would be nice to config how many backups are keept. It makes no sense to have the 3 last backups - when a update is corrupt, i need max. the last backup.