Provide an option to disable HTML emails#9205
Merged
MorrisJobke merged 1 commit intomasterfrom Apr 16, 2018
Merged
Conversation
MorrisJobke
requested review from
MariusBluem,
blizzz,
nickvergessen and
rullzer
Member
|
😘😅 |
MariusBluem
reviewed
Apr 16, 2018
| * Email will be send by default with an HTML and a plain text body. This option | ||
| * allows to only send plain text emails. | ||
| */ | ||
| 'mail_send_plaintext_only' => false, |
Member
There was a problem hiding this comment.
Does it make sense to set a mail_template_class if mail_send_plaintext_only is true? Does this even work? If no - could we merge those two settings together?
Member
There was a problem hiding this comment.
yes, you can still replace text with the template class.
nickvergessen
approved these changes
Apr 16, 2018
MorrisJobke
force-pushed
the
plaintext-emails
branch
from
096313b to
2e56281
Compare
Codecov Report
@@ Coverage Diff @@
## master #9205 +/- ##
============================================
+ Coverage 51.9% 51.91% +<.01%
- Complexity 25354 25358 +4
============================================
Files 1606 1606
Lines 95301 95307 +6
Branches 1394 1394
============================================
+ Hits 49465 49475 +10
+ Misses 45836 45832 -4
|
MorrisJobke
force-pushed
the
plaintext-emails
branch
from
2e56281 to
0574114
Compare
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
force-pushed
the
plaintext-emails
branch
from
0574114 to
9ee1feb
Compare
MorrisJobke
added
4. to release
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs to be back ported to stable12 to fix an issue with IBM notes (see #9102).
Unit tests are included.
Fixes #9031