Conversation
icewind1991
previously requested changes
Mar 20, 2018
lib/private/Files/Node/Folder.php
Outdated
| )); | ||
| }, $mountsContainingFile); | ||
|
|
||
| $nodes = array_filter($nodes, function ($x) { |
Member
There was a problem hiding this comment.
You can leave out the callback argument to filter out any falseish values
Member
Author
There was a problem hiding this comment.
Ah fair enough. was late yesterday.
Member
|
Looks good otherwise |
Member
Author
|
I'll fix the tests later as well |
Fixes #8890 In case you have access to a file via multiple ways, for example: 1. the file is shared with you with permission read only 2. the folder containing the file is shared with your read/write Requesting the getById function on the userFolder would give back two entries but both with the same permissions. Depending on the node you picked this is not right. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Codecov Report
@@ Coverage Diff @@
## master #8891 +/- ##
============================================
- Coverage 53.3% 51.96% -1.34%
- Complexity 23969 25270 +1301
============================================
Files 1509 1603 +94
Lines 89488 94878 +5390
Branches 1388 1388
============================================
+ Hits 47703 49305 +1602
- Misses 41785 45573 +3788
|
rullzer
requested review from
ChristophWurst,
MorrisJobke,
juliusknorr and
nickvergessen
Member
Author
|
Review time! |
ChristophWurst
approved these changes
Mar 22, 2018
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Change makes sense and code looks good 👍 from me
icewind1991
approved these changes
Mar 22, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8890
In case you have access to a file via multiple ways, for example:
Requesting the getById function on the userFolder would give back two
entries but both with the same permissions. Depending on the node you
picked this is not right.
@icewind1991 please have a look. I realize this is a little less optimized. But it is now correct I think.