group existence check works without attribute (like with users)#8835
Merged
MorrisJobke merged 1 commit intomasterfrom Mar 16, 2018
Merged
group existence check works without attribute (like with users)#8835MorrisJobke merged 1 commit intomasterfrom
MorrisJobke merged 1 commit intomasterfrom
Conversation
cn is not necessarily given everywhere Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
added
bug
3. to review
blizzz
changed the title
MorrisJobke
approved these changes
Mar 15, 2018
rullzer
approved these changes
Mar 16, 2018
This was referenced Mar 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the hard coded attribute was not necessarily everywhere present. Common among the big players, but we had a case where the group definition did not carry it. As with groups, the pure existence check, that is happening (along the with the group filter to apply restrictions), succeeds with an empty parameter.
One liner essentially.
@nextcloud/ldap