Add PHP 7.1 drone tests by LukasReschke · Pull Request #836 · nextcloud/server

LukasReschke · 2016-08-11T11:57:50Z

Build should fail. But we can then step by step add fixes and merge when green :)

mention-bot · 2016-08-11T11:57:51Z

@LukasReschke, thanks for your PR! By analyzing the annotation information on this pull request, we identified @MorrisJobke and @rullzer to be potential reviewers

LukasReschke · 2016-08-11T12:13:03Z

Ref guzzle/guzzle#1393 for the Guzzle error that upstream exists. But since we updated Guzzle it may be already fixed.

LukasReschke · 2016-08-11T12:16:49Z

Details


There were 13 failures:

1) Test\IntegrityCheck\CheckerTest::testVerifyAppSignatureWithValidSignatureData
Failed asserting that Array &0 (
   'EXCEPTION' => Array &1 (
       'class' => 'PHPUnit_Framework_Error_Warning'
       'message' => 'A non-numeric value encountered'
   )
) is identical to Array &0 ().

/drone/src/github.com/nextcloud/server/tests/lib/IntegrityCheck/CheckerTest.php:177

2) Test\IntegrityCheck\CheckerTest::testVerifyAppSignatureWithTamperedSignatureData
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
Array (
    'EXCEPTION' => Array (
-        'class' => 'OC\IntegrityCheck\Exceptions\InvalidSignatureException'
-        'message' => 'Signature could not get verified.'
+        'class' => 'PHPUnit_Framework_Error_Warning'
+        'message' => 'A non-numeric value encountered'
    )
)

/drone/src/github.com/nextcloud/server/tests/lib/IntegrityCheck/CheckerTest.php:225

3) Test\IntegrityCheck\CheckerTest::testVerifyAppSignatureWithTamperedFiles
Failed asserting that Array &0 (
   'EXCEPTION' => Array &1 (
       'class' => 'PHPUnit_Framework_Error_Warning'
       'message' => 'A non-numeric value encountered'
   )
) is identical to Array &0 (
   'INVALID_HASH' => Array &1 (
       'AnotherFile.txt' => Array &2 (
           'expected' => '1570ca9420e37629de4328f48c51da29840ddeaa03ae733da4bf1d854b8364f594aac560601270f9e1797ed4cd57c1aea87bf44cf4245295c94f2e935a2f0112'
           'current' => '7322348ba269c6d5522efe02f424fa3a0da319a7cd9c33142a5afe32a2d9af2da3a411f086fcfc96ff4301ea566f481dba0960c2abeef3594c4d930462f6584c'
       )
   )
   'FILE_MISSING' => Array &3 (
       'subfolder/file.txt' => Array &4 (
           'expected' => '410738545fb623c0a5c8a71f561e48ea69e3ada0981a455e920a5ae9bf17c6831ae654df324f9328ff8453de179276ae51931cca0fa71fe8ccde6c083ca0574b'
           'current' => ''
       )
   )
   'EXTRA_FILE' => Array &5 (
       'UnecessaryFile' => Array &6 (
           'expected' => ''
           'current' => 'cf83e1357eefb8bdf1542850d66d8007d620e4050b5715dc83f4a921d36ce9ce47d0d13c5d85f2b0ff8318d2877eec2f63b931bd47417a81a538327af927da3e'
       )
   )
).

/drone/src/github.com/nextcloud/server/tests/lib/IntegrityCheck/CheckerTest.php:289

4) Test\IntegrityCheck\CheckerTest::testVerifyAppSignatureWithTamperedFilesAndAlternatePath
Failed asserting that Array &0 (
   'EXCEPTION' => Array &1 (
       'class' => 'PHPUnit_Framework_Error_Warning'
       'message' => 'A non-numeric value encountered'
   )
) is identical to Array &0 (
   'INVALID_HASH' => Array &1 (
       'AnotherFile.txt' => Array &2 (
           'expected' => '1570ca9420e37629de4328f48c51da29840ddeaa03ae733da4bf1d854b8364f594aac560601270f9e1797ed4cd57c1aea87bf44cf4245295c94f2e935a2f0112'
           'current' => '7322348ba269c6d5522efe02f424fa3a0da319a7cd9c33142a5afe32a2d9af2da3a411f086fcfc96ff4301ea566f481dba0960c2abeef3594c4d930462f6584c'
       )
   )
   'FILE_MISSING' => Array &3 (
       'subfolder/file.txt' => Array &4 (
           'expected' => '410738545fb623c0a5c8a71f561e48ea69e3ada0981a455e920a5ae9bf17c6831ae654df324f9328ff8453de179276ae51931cca0fa71fe8ccde6c083ca0574b'
           'current' => ''
       )
   )
   'EXTRA_FILE' => Array &5 (
       'UnecessaryFile' => Array &6 (
           'expected' => ''
           'current' => 'cf83e1357eefb8bdf1542850d66d8007d620e4050b5715dc83f4a921d36ce9ce47d0d13c5d85f2b0ff8318d2877eec2f63b931bd47417a81a538327af927da3e'
       )
   )
).

/drone/src/github.com/nextcloud/server/tests/lib/IntegrityCheck/CheckerTest.php:352

5) Test\IntegrityCheck\CheckerTest::testVerifyAppWithDifferentScope
Failed asserting that Array &0 (
   'EXCEPTION' => Array &1 (
       'class' => 'PHPUnit_Framework_Error_Warning'
       'message' => 'A non-numeric value encountered'
   )
) is identical to Array &0 (
   'EXCEPTION' => Array &1 (
       'class' => 'OC\IntegrityCheck\Exceptions\InvalidSignatureException'
       'message' => 'Certificate is not valid for required scope. (Requested: SomeApp, current: CN=AnotherScope)'
   )
).

/drone/src/github.com/nextcloud/server/tests/lib/IntegrityCheck/CheckerTest.php:398

6) Test\IntegrityCheck\CheckerTest::testVerifyAppWithDifferentScopeAndAlwaysTrustedCore
Failed asserting that Array &0 (
   'EXCEPTION' => Array &1 (
       'class' => 'PHPUnit_Framework_Error_Warning'
       'message' => 'A non-numeric value encountered'
   )
) is identical to Array &0 ().

/drone/src/github.com/nextcloud/server/tests/lib/IntegrityCheck/CheckerTest.php:438

7) Test\IntegrityCheck\CheckerTest::testVerifyCoreSignatureWithValidSignatureData
Failed asserting that Array &0 (
   'EXCEPTION' => Array &1 (
       'class' => 'PHPUnit_Framework_Error_Warning'
       'message' => 'A non-numeric value encountered'
   )
) is identical to Array &0 ().

/drone/src/github.com/nextcloud/server/tests/lib/IntegrityCheck/CheckerTest.php:615

8) Test\IntegrityCheck\CheckerTest::testVerifyCoreSignatureWithValidModifiedHtaccessAndUserIniSignatureData
Failed asserting that Array &0 (
   'EXCEPTION' => Array &1 (
       'class' => 'PHPUnit_Framework_Error_Warning'
       'message' => 'A non-numeric value encountered'
   )
) is identical to Array &0 ().

/drone/src/github.com/nextcloud/server/tests/lib/IntegrityCheck/CheckerTest.php:657

9) Test\IntegrityCheck\CheckerTest::testVerifyCoreSignatureWithValidSignatureDataAndNotAlphabeticOrder
Failed asserting that Array &0 (
   'EXCEPTION' => Array &1 (
       'class' => 'PHPUnit_Framework_Error_Warning'
       'message' => 'A non-numeric value encountered'
   )
) is identical to Array &0 ().

/drone/src/github.com/nextcloud/server/tests/lib/IntegrityCheck/CheckerTest.php:698

10) Test\IntegrityCheck\CheckerTest::testVerifyCoreSignatureWithTamperedSignatureData
Failed asserting that Array &0 (
   'EXCEPTION' => Array &1 (
       'class' => 'PHPUnit_Framework_Error_Warning'
       'message' => 'A non-numeric value encountered'
   )
) is identical to Array &0 (
   'EXCEPTION' => Array &1 (
       'class' => 'OC\IntegrityCheck\Exceptions\InvalidSignatureException'
       'message' => 'Signature could not get verified.'
   )
).

/drone/src/github.com/nextcloud/server/tests/lib/IntegrityCheck/CheckerTest.php:745

11) Test\IntegrityCheck\CheckerTest::testVerifyCoreSignatureWithTamperedFiles
Failed asserting that Array &0 (
   'EXCEPTION' => Array &1 (
       'class' => 'PHPUnit_Framework_Error_Warning'
       'message' => 'A non-numeric value encountered'
   )
) is identical to Array &0 (
   'INVALID_HASH' => Array &1 (
       'AnotherFile.txt' => Array &2 (
           'expected' => '1570ca9420e37629de4328f48c51da29840ddeaa03ae733da4bf1d854b8364f594aac560601270f9e1797ed4cd57c1aea87bf44cf4245295c94f2e935a2f0112'
           'current' => '7322348ba269c6d5522efe02f424fa3a0da319a7cd9c33142a5afe32a2d9af2da3a411f086fcfc96ff4301ea566f481dba0960c2abeef3594c4d930462f6584c'
       )
   )
   'FILE_MISSING' => Array &3 (
       'subfolder/file.txt' => Array &4 (
           'expected' => '410738545fb623c0a5c8a71f561e48ea69e3ada0981a455e920a5ae9bf17c6831ae654df324f9328ff8453de179276ae51931cca0fa71fe8ccde6c083ca0574b'
           'current' => ''
       )
   )
   'EXTRA_FILE' => Array &5 (
       'UnecessaryFile' => Array &6 (
           'expected' => ''
           'current' => 'cf83e1357eefb8bdf1542850d66d8007d620e4050b5715dc83f4a921d36ce9ce47d0d13c5d85f2b0ff8318d2877eec2f63b931bd47417a81a538327af927da3e'
       )
   )
).

/drone/src/github.com/nextcloud/server/tests/lib/IntegrityCheck/CheckerTest.php:807

12) Test\IntegrityCheck\CheckerTest::testVerifyCoreWithInvalidCertificate
Failed asserting that Array &0 (
   'EXCEPTION' => Array &1 (
       'class' => 'PHPUnit_Framework_Error_Warning'
       'message' => 'A non-numeric value encountered'
   )
) is identical to Array &0 (
   'EXCEPTION' => Array &1 (
       'class' => 'OC\IntegrityCheck\Exceptions\InvalidSignatureException'
       'message' => 'Certificate is not valid.'
   )
).

/drone/src/github.com/nextcloud/server/tests/lib/IntegrityCheck/CheckerTest.php:854

13) Test\IntegrityCheck\CheckerTest::testVerifyCoreWithDifferentScope
Failed asserting that Array &0 (
   'EXCEPTION' => Array &1 (
       'class' => 'PHPUnit_Framework_Error_Warning'
       'message' => 'A non-numeric value encountered'
   )
) is identical to Array &0 (
   'EXCEPTION' => Array &1 (
       'class' => 'OC\IntegrityCheck\Exceptions\InvalidSignatureException'
       'message' => 'Certificate is not valid for required scope. (Requested: core, current: CN=SomeApp)'
   )
).

/drone/src/github.com/nextcloud/server/tests/lib/IntegrityCheck/CheckerTest.php:901

1) Test\IntegrityCheck\CheckerTest::testWriteAppSignatureOfNotExistingApp
A non-numeric value encountered

/drone/src/github.com/nextcloud/server/3rdparty/phpseclib/phpseclib/phpseclib/File/ASN1.php:500
/drone/src/github.com/nextcloud/server/3rdparty/phpseclib/phpseclib/phpseclib/File/ASN1.php:600
/drone/src/github.com/nextcloud/server/3rdparty/phpseclib/phpseclib/phpseclib/File/ASN1.php:600
/drone/src/github.com/nextcloud/server/3rdparty/phpseclib/phpseclib/phpseclib/File/ASN1.php:600
/drone/src/github.com/nextcloud/server/3rdparty/phpseclib/phpseclib/phpseclib/File/X509.php:1441
/drone/src/github.com/nextcloud/server/tests/lib/IntegrityCheck/CheckerTest.php:88

2) Test\IntegrityCheck\CheckerTest::testWriteAppSignature
A non-numeric value encountered

/drone/src/github.com/nextcloud/server/3rdparty/phpseclib/phpseclib/phpseclib/File/ASN1.php:500
/drone/src/github.com/nextcloud/server/3rdparty/phpseclib/phpseclib/phpseclib/File/ASN1.php:600
/drone/src/github.com/nextcloud/server/3rdparty/phpseclib/phpseclib/phpseclib/File/ASN1.php:600
/drone/src/github.com/nextcloud/server/3rdparty/phpseclib/phpseclib/phpseclib/File/ASN1.php:600
/drone/src/github.com/nextcloud/server/3rdparty/phpseclib/phpseclib/phpseclib/File/X509.php:1441
/drone/src/github.com/nextcloud/server/tests/lib/IntegrityCheck/CheckerTest.php:114

3) Test\IntegrityCheck\CheckerTest::testWriteCoreSignature
A non-numeric value encountered

/drone/src/github.com/nextcloud/server/3rdparty/phpseclib/phpseclib/phpseclib/File/ASN1.php:500
/drone/src/github.com/nextcloud/server/3rdparty/phpseclib/phpseclib/phpseclib/File/ASN1.php:600
/drone/src/github.com/nextcloud/server/3rdparty/phpseclib/phpseclib/phpseclib/File/ASN1.php:600
/drone/src/github.com/nextcloud/server/3rdparty/phpseclib/phpseclib/phpseclib/File/ASN1.php:600
/drone/src/github.com/nextcloud/server/3rdparty/phpseclib/phpseclib/phpseclib/File/X509.php:1441
/drone/src/github.com/nextcloud/server/tests/lib/IntegrityCheck/CheckerTest.php:467

4) Test\IntegrityCheck\CheckerTest::testWriteCoreSignatureWithUnmodifiedHtaccess
A non-numeric value encountered

/drone/src/github.com/nextcloud/server/3rdparty/phpseclib/phpseclib/phpseclib/File/ASN1.php:500
/drone/src/github.com/nextcloud/server/3rdparty/phpseclib/phpseclib/phpseclib/File/ASN1.php:600
/drone/src/github.com/nextcloud/server/3rdparty/phpseclib/phpseclib/phpseclib/File/ASN1.php:600
/drone/src/github.com/nextcloud/server/3rdparty/phpseclib/phpseclib/phpseclib/File/ASN1.php:600
/drone/src/github.com/nextcloud/server/3rdparty/phpseclib/phpseclib/phpseclib/File/X509.php:1441
/drone/src/github.com/nextcloud/server/tests/lib/IntegrityCheck/CheckerTest.php:497

5) Test\IntegrityCheck\CheckerTest::testWriteCoreSignatureWithInvalidModifiedHtaccess
A non-numeric value encountered

/drone/src/github.com/nextcloud/server/3rdparty/phpseclib/phpseclib/phpseclib/File/ASN1.php:500
/drone/src/github.com/nextcloud/server/3rdparty/phpseclib/phpseclib/phpseclib/File/ASN1.php:600
/drone/src/github.com/nextcloud/server/3rdparty/phpseclib/phpseclib/phpseclib/File/ASN1.php:600
/drone/src/github.com/nextcloud/server/3rdparty/phpseclib/phpseclib/phpseclib/File/ASN1.php:600
/drone/src/github.com/nextcloud/server/3rdparty/phpseclib/phpseclib/phpseclib/File/X509.php:1441
/drone/src/github.com/nextcloud/server/tests/lib/IntegrityCheck/CheckerTest.php:522

6) Test\IntegrityCheck\CheckerTest::testWriteCoreSignatureWithValidModifiedHtaccessAndUserIni
A non-numeric value encountered

/drone/src/github.com/nextcloud/server/3rdparty/phpseclib/phpseclib/phpseclib/File/ASN1.php:500
/drone/src/github.com/nextcloud/server/3rdparty/phpseclib/phpseclib/phpseclib/File/ASN1.php:600
/drone/src/github.com/nextcloud/server/3rdparty/phpseclib/phpseclib/phpseclib/File/ASN1.php:600
/drone/src/github.com/nextcloud/server/3rdparty/phpseclib/phpseclib/phpseclib/File/ASN1.php:600
/drone/src/github.com/nextcloud/server/3rdparty/phpseclib/phpseclib/phpseclib/File/X509.php:1441
/drone/src/github.com/nextcloud/server/tests/lib/IntegrityCheck/CheckerTest.php:553

LukasReschke · 2016-08-11T12:19:38Z

phpseclib/phpseclib#1013 has the phpseclib patches

LukasReschke · 2016-08-18T20:30:15Z

phpseclib/phpseclib@15c9f99 is the breaking phpseclib commit

MorrisJobke · 2016-08-19T07:31:32Z

PHP 5.4 fails:

Details

There were 15 failures:

1) Test\IntegrityCheck\CheckerTest::testWriteAppSignature
Expectation failed for method name is equal to <string:file_put_contents> when invoked 1 time(s)
Parameter 1 for invocation OC\IntegrityCheck\Helpers\FileAccessHelper::file_put_contents('/drone/src/github.com/nextclo...e.json', '{\n    "hashes": {\n        "An...---"\n}') does not match expected value.
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
 '{
     "hashes": {
         "AnotherFile.txt": "1570ca9420e37629de4328f48c51da29840ddeaa03ae733da4bf1d854b8364f594aac560601270f9e1797ed4cd57c1aea87bf44cf4245295c94f2e935a2f0112",
         "subfolder\/file.txt": "410738545fb623c0a5c8a71f561e48ea69e3ada0981a455e920a5ae9bf17c6831ae654df324f9328ff8453de179276ae51931cca0fa71fe8ccde6c083ca0574b"
     },
-    "signature": "Y5yvXvcGHVPuRRatKVDUONWq1FpLXugZd6Km\/+aEHsQj7coVl9FeMj9OsWamBf7yRIw3dtNLguTLlAA9QAv\/b0uHN3JnbNZN+dwFOve4NMtqXfSDlWftqKN00VS+RJXpG1S2IIx9Poyp2NoghL\/5AuTv4GHiNb7zU\/DT\/kt71pUGPgPR6IIFaE+zHOD96vjYkrH+GfWZzKR0FCdLib9yyNvk+EGrcjKM6qjs2GKfS\/XFjj\/\/neDnh\/0kcPuKE3ZbofnI4TIDTv0CGqvOp7PtqVNc3Vy\/UKa7uF1PT0MAUKMww6EiMUSFZdUVP4WWF0Y72W53Qdtf1hrAZa2kfKyoK5kd7sQmCSKUPSU8978AUVZlBtTRlyT803IKwMV0iHMkw+xYB1sN2FlHup\/DESADqxhdgYuK35bCPvgkb4SBe4B8Voz\/izTvcP7VT5UvkYdAO+05\/jzdaHEmzmsD92CFfvX0q8O\/Y\/29ubftUJsqcHeMDKgcR4eZOE8+\/QVc\/89QO6WnKNuNuV+5bybO6g6PAdC9ZPsCvnihS61O2mwRXHLR3jv2UleFWm+lZEquPKtkhi6SLtDiijA4GV6dmS+dzujSLb7hGeD5o1plZcZ94uhWljl+QIp82+zU\/lYB1Zfr4Mb4e+V7r2gv7Fbv7y6YtjE2GIQwRhC5jq56bD0ZB+I=",
+    "signature": "ny\/CJBgqFWN5k\/nAhqu7vQF0HFPvnbH9hueXi7FruiyocbxB67w5GD4B58822mK\/wmW7STMTuvtRE3jBQA4h7v+ip6ElH2JEv2aHi6B\/lIGLgYMQUZW7Nch8GE8u14VnzlZVX9z0EghpgnPy6C\/yxweHVrYf4g83if0BEnwsb1PzKETLvOCSNGcrL2LNhrRS2+6Ya4jElNU+knM\/Dv6bg7I9xIU3BirTHyRA2L2sn3Qp+ny5h00hrOzdzNP9nGd5O6Fr+Pm+5ZHiAly24SOeZnKyAj9vzfXl7f5Pj7nhQiOC9FXHc7tD5667H2yYuITC32DG5QlwMKc7ebvTFlVFrf4fAe\/hkKkaoOKDpN7vF8Fm3HPqkY0EIEA5GmBPzKS6YM8FCODaNgo6VGIpD8jC0Tzf22bpfzNyQonw4kYjffxGYkyHk1b2I+POQCVu1inCNRb\/oygZvNopmsPayVSeovlxTVmdQbWwSm6RLnjUr4b0PywFn1HIlLitNUExmC\/UC+13bfpixZcLY9XmxUD3vS2m45uI2m3nWKNv5iR4lCbdpqwyDwa1hmrGiJGV5rCzmlFVp432qYSAHFHOG6gfajCIJtEl9R11gHsyn+8Ilte8v9Di3sPEA+K0Lgu2XFbzsqYfXYSZL\/Tdw6WwdCySWXWo3TvhBglPUkIEGscY75I=",
     "certificate": "-----BEGIN CERTIFICATE-----\r\nMIIEwTCCAqmgAwIBAgIUWv0iujufs5lUr0svCf\/qTQvoyKAwDQYJKoZIhvcNAQEF\r\nBQAwIzEhMB8GA1UECgwYb3duQ2xvdWQgQ29kZSBTaWduaW5nIENBMB4XDTE1MTEw\r\nMzIyNDk1M1oXDTE2MTEwMzIyNDk1M1owEjEQMA4GA1UEAwwHU29tZUFwcDCCAiIw\r\nDQYJKoZIhvcNAQEBBQADggIPADCCAgoCggIBAK8q0x62agGSRBqeWsaeEwFfepMk\r\nF8cAobMMi50qHCv9IrOn\/ZH9l52xBrbIkErVmRjmly0d4JhD8Ymhidsh9ONKYl\/j\r\n+ishsZDM8eNNdp3Ew+fEYVvY1W7mR1qU24NWj0bzVsClI7hvPVIuw7AjfBDq1C5+\r\nA+ZSLSXYvOK2cEWjdxQfuNZwEZSjmA63DUllBIrm35IaTvfuyhU6BW9yHZxmb8+M\r\nw0xDv30D5UkE\/2N7Pa\/HQJLxCR+3zKibRK3nUyRDLSXxMkU9PnFNaPNX59VPgyj4\r\nGB1CFSToldJVPF4pzh7p36uGXZVxs8m3LFD4Ol8mhi7jkxDZjqFN46gzR0r23Py6\r\ndol9vfawGIoUwp9LvL0S7MvdRY0oazLXwClLP4OQ17zpSMAiCj7fgNT661JamPGj\r\nt5O7Zn2wA7I4ddDS\/HDTWCu98Zwc9fHIpsJPgCZ9awoqxi4Mnf7Pk9g5nnXhszGC\r\ncxxIASQKM+GhdzoRxKknax2RzUCwCzcPRtCj8AQT\/x\/mqN3PfRmlnFBNACUw9bpZ\r\nSOoNq2pCF9igftDWpSIXQ38pVpKLWowjjg3DVRmVKBgivHnUnVLyzYBahHPj0vaz\r\ntFtUFRaqXDnt+4qyUGyrT5h5pjZaTcHIcSB4PiarYwdVvgslgwnQzOUcGAzRWBD4\r\n6jV2brP5vFY3g6iPAgMBAAEwDQYJKoZIhvcNAQEFBQADggIBACTY3CCHC+Z28gCf\r\nFWGKQ3wAKs+k4+0yoti0qm2EKX7rSGQ0PHSas6uW79WstC4Rj+DYkDtIhGMSg8FS\r\nHVGZHGBCc0HwdX+BOAt3zi4p7Sf3oQef70\/4imPoKxbAVCpd\/cveVcFyDC19j1yB\r\nBapwu87oh+muoeaZxOlqQI4UxjBlR\/uRSMhOn2UGauIr3dWJgAF4pGt7TtIzt+1v\r\n0uA6FtN1Y4R5O8AaJPh1bIG0CVvFBE58esGzjEYLhOydgKFnEP94kVPgJD5ds9C3\r\npPhEpo1dRpiXaF7WGIV1X6DI\/ipWvfrF7CEy6I\/kP1InY\/vMDjQjeDnJ\/VrXIWXO\r\nyZvHXVaN\/m+1RlETsH7YO\/QmxRue9ZHN3gvvWtmpCeA95sfpepOk7UcHxHZYyQbF\r\n49\/au8j+5tsr4A83xzsT1JbcKRxkAaQ7WDJpOnE5O1+H0fB+BaLakTg6XX9d4Fo7\r\n7Gin7hVWX7pL+JIyxMzME3LhfI61+CRcqZQIrpyaafUziPQbWIPfEs7h8tCOWyvW\r\nUO8ZLervYCB3j44ivkrxPlcBklDCqqKKBzDP9dYOtS\/P4RB1NkHA9+NTvmBpTonS\r\nSFXdg9fFMD7VfjDE3Vnk+8DWkVH5wBYowTAD7w9Wuzr7DumiAULexnP\/Y7xwxLv7\r\n4B+pXTAcRK0zECDEaX3npS8xWzrB\r\n-----END CERTIFICATE-----"
 }'

/drone/src/github.com/nextcloud/server/lib/private/IntegrityCheck/Checker.php:281
/drone/src/github.com/nextcloud/server/tests/lib/IntegrityCheck/CheckerTest.php:115

2) Test\IntegrityCheck\CheckerTest::testVerifyAppSignatureWithValidSignatureData
Failed asserting that Array &0 (
    'EXCEPTION' => Array &1 (
        'class' => 'OC\IntegrityCheck\Exceptions\InvalidSignatureException'
        'message' => 'Signature could not get verified.'
    )
) is identical to Array &0 ().

/drone/src/github.com/nextcloud/server/tests/lib/IntegrityCheck/CheckerTest.php:177

3) Test\IntegrityCheck\CheckerTest::testVerifyAppSignatureWithTamperedFiles
Failed asserting that Array &0 (
    'EXCEPTION' => Array &1 (
        'class' => 'OC\IntegrityCheck\Exceptions\InvalidSignatureException'
        'message' => 'Signature could not get verified.'
    )
) is identical to Array &0 (
    'INVALID_HASH' => Array &1 (
        'AnotherFile.txt' => Array &2 (
            'expected' => '1570ca9420e37629de4328f48c51da29840ddeaa03ae733da4bf1d854b8364f594aac560601270f9e1797ed4cd57c1aea87bf44cf4245295c94f2e935a2f0112'
            'current' => '7322348ba269c6d5522efe02f424fa3a0da319a7cd9c33142a5afe32a2d9af2da3a411f086fcfc96ff4301ea566f481dba0960c2abeef3594c4d930462f6584c'
        )
    )
    'FILE_MISSING' => Array &3 (
        'subfolder/file.txt' => Array &4 (
            'expected' => '410738545fb623c0a5c8a71f561e48ea69e3ada0981a455e920a5ae9bf17c6831ae654df324f9328ff8453de179276ae51931cca0fa71fe8ccde6c083ca0574b'
            'current' => ''
        )
    )
    'EXTRA_FILE' => Array &5 (
        'UnecessaryFile' => Array &6 (
            'expected' => ''
            'current' => 'cf83e1357eefb8bdf1542850d66d8007d620e4050b5715dc83f4a921d36ce9ce47d0d13c5d85f2b0ff8318d2877eec2f63b931bd47417a81a538327af927da3e'
        )
    )
).

/drone/src/github.com/nextcloud/server/tests/lib/IntegrityCheck/CheckerTest.php:289

4) Test\IntegrityCheck\CheckerTest::testVerifyAppSignatureWithTamperedFilesAndAlternatePath
Failed asserting that Array &0 (
    'EXCEPTION' => Array &1 (
        'class' => 'OC\IntegrityCheck\Exceptions\InvalidSignatureException'
        'message' => 'Signature could not get verified.'
    )
) is identical to Array &0 (
    'INVALID_HASH' => Array &1 (
        'AnotherFile.txt' => Array &2 (
            'expected' => '1570ca9420e37629de4328f48c51da29840ddeaa03ae733da4bf1d854b8364f594aac560601270f9e1797ed4cd57c1aea87bf44cf4245295c94f2e935a2f0112'
            'current' => '7322348ba269c6d5522efe02f424fa3a0da319a7cd9c33142a5afe32a2d9af2da3a411f086fcfc96ff4301ea566f481dba0960c2abeef3594c4d930462f6584c'
        )
    )
    'FILE_MISSING' => Array &3 (
        'subfolder/file.txt' => Array &4 (
            'expected' => '410738545fb623c0a5c8a71f561e48ea69e3ada0981a455e920a5ae9bf17c6831ae654df324f9328ff8453de179276ae51931cca0fa71fe8ccde6c083ca0574b'
            'current' => ''
        )
    )
    'EXTRA_FILE' => Array &5 (
        'UnecessaryFile' => Array &6 (
            'expected' => ''
            'current' => 'cf83e1357eefb8bdf1542850d66d8007d620e4050b5715dc83f4a921d36ce9ce47d0d13c5d85f2b0ff8318d2877eec2f63b931bd47417a81a538327af927da3e'
        )
    )
).

/drone/src/github.com/nextcloud/server/tests/lib/IntegrityCheck/CheckerTest.php:352

5) Test\IntegrityCheck\CheckerTest::testVerifyAppWithDifferentScope
Failed asserting that Array &0 (
    'EXCEPTION' => Array &1 (
        'class' => 'PHPUnit_Framework_Error_Notice'
        'message' => 'Array to string conversion'
    )
) is identical to Array &0 (
    'EXCEPTION' => Array &1 (
        'class' => 'OC\IntegrityCheck\Exceptions\InvalidSignatureException'
        'message' => 'Certificate is not valid for required scope. (Requested: SomeApp, current: CN=AnotherScope)'
    )
).

/drone/src/github.com/nextcloud/server/tests/lib/IntegrityCheck/CheckerTest.php:398

6) Test\IntegrityCheck\CheckerTest::testVerifyAppWithDifferentScopeAndAlwaysTrustedCore
Failed asserting that Array &0 (
    'EXCEPTION' => Array &1 (
        'class' => 'OC\IntegrityCheck\Exceptions\InvalidSignatureException'
        'message' => 'Signature could not get verified.'
    )
) is identical to Array &0 ().

/drone/src/github.com/nextcloud/server/tests/lib/IntegrityCheck/CheckerTest.php:438

7) Test\IntegrityCheck\CheckerTest::testWriteCoreSignature
Expectation failed for method name is equal to <string:file_put_contents> when invoked 1 time(s)
Parameter 1 for invocation OC\IntegrityCheck\Helpers\FileAccessHelper::file_put_contents('/drone/src/github.com/nextclo...e.json', '{\n    "hashes": {\n        "An...---"\n}') does not match expected value.
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
 '{
     "hashes": {
         "AnotherFile.txt": "1570ca9420e37629de4328f48c51da29840ddeaa03ae733da4bf1d854b8364f594aac560601270f9e1797ed4cd57c1aea87bf44cf4245295c94f2e935a2f0112",
         "subfolder\/file.txt": "410738545fb623c0a5c8a71f561e48ea69e3ada0981a455e920a5ae9bf17c6831ae654df324f9328ff8453de179276ae51931cca0fa71fe8ccde6c083ca0574b"
     },
-    "signature": "dYoohBaWIFR\/To1FXEbMQB5apUhVYlEauBGSPo12nq84wxWkBx2EM3KDRgkB5Sub2tr0CgmAc2EVjPhKIEzAam26cyUb48bJziz1V6wvW7z4GZAfaJpzLkyHdSfV5117VSf5w1rDcAeZDXfGUaaNEJPWytaF4ZIxVge7f3NGshHy4odFVPADy\/u6c43BWvaOtJ4m3aJQbP6sxCO9dxwcm5yJJJR3n36jfh229sdWBxyl8BhwhH1e1DEv78\/aiL6ckKFPVNzx01R6yDFt3TgEMR97YZ\/R6lWiXG+dsJ305jNFlusLu518zBUvl7g5yjzGN778H29b2C8VLZKmi\/h1CH9jGdD72fCqCYdenD2uZKzb6dsUtXtvBmVcVT6BUGz41W1pkkEEB+YJpMrHILIxAiHRGv1+aZa9\/Oz8LWFd+BEUQjC2LJgojPnpzaG\/msw1nBkX16NNVDWWtJ25Bc\/r\/mG46rwjWB\/cmV6Lwt6KODiqlxgrC4lm9ALOCEWw+23OcYhLwNfQTYevXqHqsFfXOkhUnM8z5vDUb\/HBraB1DjFXN8iLK+1YewD4P495e+SRzrR79Oi3F8SEqRIzRLfN2rnW1BTms\/wYsz0p67cup1Slk1XlNmHwbWX25NVd2PPlLOvZRGoqcKFpIjC5few8THiZfyjiNFwt3RM0AFdZcXY=",
+    "signature": "kReoH+G8jYy3pBbMHie4upIMIuBP8OPezpHlYqUpguzceE18+G7dz+94U1AAAotqb49L3X+geUw5C90OF44Vr6n7LD\/qwDBlKfByBnJt7w8ABHHOfHDH19VOJLu3RE\/NpbZCtJgyC1iC\/0Dxnhid\/Ume4mkEqpbpILc1COf3FjKV5FfiBHNrpP\/Mbpdb+LMlxbOmJewd2j5XdxV3y3QyVhlsnG476HPliVZYFq\/XOdDQoLL6mPyE500ItZZkqa1KpkFoTKM5dUhkTFzRqjdCq\/bVESBcvAFCkGJVQTxbVmyvxUvZAOptQehDDcDcJdalreMEBFL0jGlna0a79gTtSaeKS4dIZsKMguWRFinkyNK88N3KKnzsaw0Hq4OCspifOCykcvKavWZLGl6VttA23N2tCG81cAv1XyBoJrgALRcFZRmgP9xtKvNIxegBJ1Fi9oyocs3G4NFAf\/WbZ0mob6XtHpvE\/vn4ZQGuygX3qvZWclvbrJARUuUgBDyNbklpJyagqybFnpSVN9h3LHt+z1cvjvCQj2A2mT9dcfzlBGkhT1F539deoI44ijsCiHWWQl6GixJnuKc3kn15GbLtOo3A+aJXzY++1dK\/9hiPHfCxW8Rvm0SC+Ak4utQgFC62YhO9YJBBDWcJCn9NPt7jaNGvrgcONP4m1nvFQr8Ni3o=",
     "certificate": "-----BEGIN CERTIFICATE-----\r\nMIIEvjCCAqagAwIBAgIUc\/0FxYrsgSs9rDxp03EJmbjN0NwwDQYJKoZIhvcNAQEF\r\nBQAwIzEhMB8GA1UECgwYb3duQ2xvdWQgQ29kZSBTaWduaW5nIENBMB4XDTE1MTEw\r\nMzIxMDMzM1oXDTE2MTEwMzIxMDMzM1owDzENMAsGA1UEAwwEY29yZTCCAiIwDQYJ\r\nKoZIhvcNAQEBBQADggIPADCCAgoCggIBALb6EgHpkAqZbO5vRO8XSh7G7XGWHw5s\r\niOf4RwPXR6SE9bWZEm\/b72SfWk\/\/J6AbrD8WiOzBuT\/ODy6k5T1arEdHO+Pux0W1\r\nMxYJJI4kH74KKgMpC0SB0Rt+8WrMqV1r3hhJ46df6Xr\/xolP3oD+eLbShPcblhdS\r\nVtkZEkoev8Sh6L2wDCeHDyPxzvj1w2dTdGVO9Kztn0xIlyfEBakqvBWtcxyi3Ln0\r\nklnxlMx3tPDUE4kqvpia9qNiB1AN2PV93eNr5\/2riAzIssMFSCarWCx0AKYb54+d\r\nxLpcYFyqPJ0ydBCkF78DD45RCZet6PNYkdzgbqlUWEGGomkuDoJbBg4wzgzO0D77\r\nH87KFhYW8tKFFvF1V3AHl\/sFQ9tDHaxM9Y0pZ2jPp\/ccdiqnmdkBxBDqsiRvHvVB\r\nCn6qpb4vWGFC7vHOBfYspmEL1zLlKXZv3ezMZEZw7O9ZvUP3VO\/wAtd2vUW8UFiq\r\ns2v1QnNLN6jNh51obcwmrBvWhJy9vQIdtIjQbDxqWTHh1zUSrw9wrlklCBZ\/zrM0\r\ni8nfCFwTxWRxp3H9KoECzO\/zS5R5KIS7s3\/wq\/w9T2Ie4rcecgXwDizwnn0C\/aKc\r\nbDIjujpL1s9HO05pcD\/V3wKcPZ1izymBkmMyIbL52iRVN5FTVHeZdXPpFuq+CTQJ\r\nQ238lC+A\/KOVAgMBAAEwDQYJKoZIhvcNAQEFBQADggIBAGoKTnh8RfJV4sQItVC2\r\nAvfJagkrIqZ3iiQTUBQGTKBsTnAqE1H7QgUSV9vSd+8rgvHkyZsRjmtyR1e3A6Ji\r\noNCXUbExC\/0iCPUqdHZIVb+Lc\/vWuv4ByFMybGPydgtLoEUX2ZrKFWmcgZFDUSRd\r\n9Uj26vtUhCC4bU4jgu6hIrR9IuxOBLQUxGTRZyAcXvj7obqRAEZwFAKQgFpfpqTb\r\nH+kjcbZSaAlLVSF7vBc1syyI8RGYbqpwvtREqJtl5IEIwe6huEqJ3zPnlP2th\/55\r\ncf3Fovj6JJgbb9XFxrdnsOsDOu\/tpnaRWlvv5ib4+SzG5wWFT5UUEo4Wg2STQiiX\r\nuVSRQxK1LE1yg84bs3NZk9FSQh4B8vZVuRr5FaJsZZkwlFlhRO\/\/+TJtXRbyNgsf\r\noMRZGi8DLGU2SGEAHcRH\/QZHq\/XDUWVzdxrSBYcy7GSpT7UDVzGv1rEJUrn5veP1\r\n0KmauAqtiIaYRm4f6YBsn0INcZxzIPZ0p8qFtVZBPeHhvQtvOt0iXI\/XUxEWOa2F\r\nK2EqhErgMK\/N07U1JJJay5tYZRtvkGq46oP\/5kQG8hYST0MDK6VihJoPpvCmAm4E\r\npEYKQ96x6A4EH9Y9mZlYozH\/eqmxPbTK8n89\/p7Ydun4rI+B2iiLnY8REWWy6+UQ\r\nV204fGUkJqW5CrKy3P3XvY9X\r\n-----END CERTIFICATE-----"
 }'

/drone/src/github.com/nextcloud/server/lib/private/IntegrityCheck/Checker.php:300
/drone/src/github.com/nextcloud/server/tests/lib/IntegrityCheck/CheckerTest.php:468

8) Test\IntegrityCheck\CheckerTest::testWriteCoreSignatureWithUnmodifiedHtaccess
Expectation failed for method name is equal to <string:file_put_contents> when invoked 1 time(s)
Parameter 1 for invocation OC\IntegrityCheck\Helpers\FileAccessHelper::file_put_contents('/drone/src/github.com/nextclo...e.json', '{\n    "hashes": {\n        ".h...---"\n}') does not match expected value.
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
 '{
     "hashes": {
         ".htaccess": "dc479770a6232061e04a768ee1f9133fdb3aea7b3a99f7105b0e0b6197474733e8d14b5b2bbad054e6b62a410fe5d0b3d790242dee1e0f11274af2100f5289e2",
         "subfolder\/.htaccess": "2c57b1e25050e11dc3ae975832f378c452159f7b69f818e47eeeafadd6ba568517461dcb4d843b90b906cd7c89d161bc1b89dff8e3ae0eb6f5088508c47befd1"
     },
-    "signature": "nRtR377DB\/I\/4hmh9q3elMQYfSHnQFlNtjchNgrdfmUQqVmgkU\/4qgGyxDqYkV8mSMbH2gYysfP42nx\/3zSo7n0dBYDfU87Q6f96Cv597vEV27do8CaBkEk8Xjn2SxhHw8hVxracvE2OBAPxk0H3sRp\/cQBgjoXpju4kQin0N5E+DEJMh7Sp+u8aKoFpb+2FaAZJFn\/hnqxLTlVi2nyDxGL3U0eobWY+jWH9XPt52v3Hyh8TDhcAnQ1cN30B8Jn2+jkrm8ib+buchaCXHk0cPX72xuPECdwOEKLCBNrJa3FGSvO1zWiecnCgxCXgt+R8hUgsVPTsbrdFY2YRJGIhHndYZL98XzgG7cw85SnnMMe2SulzeL7xANGF8qiEVyiC7x83bbj5xOkeM\/CUTajrLBO3vyZ23KKOxvskjgI0t+Zw1zFsl+sYW0\/O\/V5WzPOwMwV8+iApQ8k9gEMiYQg98QLEMYnSohncmp0Z9qx2qFcQuHLcKJVa1J6wGtE\/EHR\/4d0aYPd6IRjg+qshCJmdzud\/12xjpGTl+BT0Hi0VsU5o7ZMi7WhmukZmmv8u0uZsvKREQNATm4cO4WCkYySt5O9gZEJOF+jjgeynDoAh09lyrNXIgMpM9ufm\/XEG\/I\/f2zIwbAUc6J6qks5OuYlJzW5vscTiOKhwcGZU9WBLgh0=",
+    "signature": "pk6Fkbyva7TkVA9g28ZC6jxqaO58kNRGVqqCBGylak3xLBJhwdjg7WEj\/VGIAaD0jq\/\/bi09xG\/Jpwue5ifQtAhW4A735WAGDc2E1mj8Ka1MgcSIKww+bPJwpCu+71ziYE1cfhTi7kN8GHGnwTZJOUPvW9P\/rUp1A6o7ZbjYxvrNEX+UIz3Nz2lUZWcIW4Mtb6QrsbX\/O2+LfgbrP0L7YTq0xG\/IkDZZJFpC37aNfxbZKVOm6vqlWAShqQx5lMfkW2SCPZ+Ju3ziznveRTwFXLRSe4HLOMcYpjuVfNxfMaeqZmELv1arp701bPF0UbFmuaxX2DHgBmuRu6LY9HuGcn+vnL6JHiYHj27UHtHINVd+yorMH8qypuLT7JF6sl0J0JSMUcQm8IzmMGQFZt56h+9qsuk3pwErGeHEQ4DYCHRN5JjSwunLKpE57ptuajRrOa9OMGZcuwPH+D7xH8YahQPlicIsezy3nj4dLoIbV+tGBQrFT97SmTkjGqIRgIdoaJNEOJ2ApuP+3WZrnBlIatDFCnYUP4QvqEvZjieZQ+bB2MDMWj75U+V2x1PSMjr\/u2s+KfbprbzCgQT7vDaeHk41AYe8T\/4yQOE65ZDLaiD3N\/+3fBxX6OsGpEXYbxoQrrTh2hd4Qkzr3fNmLKk8NShRQto6uGjIvfOqh1456ag=",
     "certificate": "-----BEGIN CERTIFICATE-----\r\nMIIEvjCCAqagAwIBAgIUc\/0FxYrsgSs9rDxp03EJmbjN0NwwDQYJKoZIhvcNAQEF\r\nBQAwIzEhMB8GA1UECgwYb3duQ2xvdWQgQ29kZSBTaWduaW5nIENBMB4XDTE1MTEw\r\nMzIxMDMzM1oXDTE2MTEwMzIxMDMzM1owDzENMAsGA1UEAwwEY29yZTCCAiIwDQYJ\r\nKoZIhvcNAQEBBQADggIPADCCAgoCggIBALb6EgHpkAqZbO5vRO8XSh7G7XGWHw5s\r\niOf4RwPXR6SE9bWZEm\/b72SfWk\/\/J6AbrD8WiOzBuT\/ODy6k5T1arEdHO+Pux0W1\r\nMxYJJI4kH74KKgMpC0SB0Rt+8WrMqV1r3hhJ46df6Xr\/xolP3oD+eLbShPcblhdS\r\nVtkZEkoev8Sh6L2wDCeHDyPxzvj1w2dTdGVO9Kztn0xIlyfEBakqvBWtcxyi3Ln0\r\nklnxlMx3tPDUE4kqvpia9qNiB1AN2PV93eNr5\/2riAzIssMFSCarWCx0AKYb54+d\r\nxLpcYFyqPJ0ydBCkF78DD45RCZet6PNYkdzgbqlUWEGGomkuDoJbBg4wzgzO0D77\r\nH87KFhYW8tKFFvF1V3AHl\/sFQ9tDHaxM9Y0pZ2jPp\/ccdiqnmdkBxBDqsiRvHvVB\r\nCn6qpb4vWGFC7vHOBfYspmEL1zLlKXZv3ezMZEZw7O9ZvUP3VO\/wAtd2vUW8UFiq\r\ns2v1QnNLN6jNh51obcwmrBvWhJy9vQIdtIjQbDxqWTHh1zUSrw9wrlklCBZ\/zrM0\r\ni8nfCFwTxWRxp3H9KoECzO\/zS5R5KIS7s3\/wq\/w9T2Ie4rcecgXwDizwnn0C\/aKc\r\nbDIjujpL1s9HO05pcD\/V3wKcPZ1izymBkmMyIbL52iRVN5FTVHeZdXPpFuq+CTQJ\r\nQ238lC+A\/KOVAgMBAAEwDQYJKoZIhvcNAQEFBQADggIBAGoKTnh8RfJV4sQItVC2\r\nAvfJagkrIqZ3iiQTUBQGTKBsTnAqE1H7QgUSV9vSd+8rgvHkyZsRjmtyR1e3A6Ji\r\noNCXUbExC\/0iCPUqdHZIVb+Lc\/vWuv4ByFMybGPydgtLoEUX2ZrKFWmcgZFDUSRd\r\n9Uj26vtUhCC4bU4jgu6hIrR9IuxOBLQUxGTRZyAcXvj7obqRAEZwFAKQgFpfpqTb\r\nH+kjcbZSaAlLVSF7vBc1syyI8RGYbqpwvtREqJtl5IEIwe6huEqJ3zPnlP2th\/55\r\ncf3Fovj6JJgbb9XFxrdnsOsDOu\/tpnaRWlvv5ib4+SzG5wWFT5UUEo4Wg2STQiiX\r\nuVSRQxK1LE1yg84bs3NZk9FSQh4B8vZVuRr5FaJsZZkwlFlhRO\/\/+TJtXRbyNgsf\r\noMRZGi8DLGU2SGEAHcRH\/QZHq\/XDUWVzdxrSBYcy7GSpT7UDVzGv1rEJUrn5veP1\r\n0KmauAqtiIaYRm4f6YBsn0INcZxzIPZ0p8qFtVZBPeHhvQtvOt0iXI\/XUxEWOa2F\r\nK2EqhErgMK\/N07U1JJJay5tYZRtvkGq46oP\/5kQG8hYST0MDK6VihJoPpvCmAm4E\r\npEYKQ96x6A4EH9Y9mZlYozH\/eqmxPbTK8n89\/p7Ydun4rI+B2iiLnY8REWWy6+UQ\r\nV204fGUkJqW5CrKy3P3XvY9X\r\n-----END CERTIFICATE-----"
 }'

/drone/src/github.com/nextcloud/server/lib/private/IntegrityCheck/Checker.php:300
/drone/src/github.com/nextcloud/server/tests/lib/IntegrityCheck/CheckerTest.php:498

9) Test\IntegrityCheck\CheckerTest::testWriteCoreSignatureWithInvalidModifiedHtaccess
Expectation failed for method name is equal to <string:file_put_contents> when invoked 1 time(s)
Parameter 1 for invocation OC\IntegrityCheck\Helpers\FileAccessHelper::file_put_contents('/drone/src/github.com/nextclo...e.json', '{\n    "hashes": {\n        ".h...---"\n}') does not match expected value.
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
 '{
     "hashes": {
         ".htaccess": "4a54273dc8d697b2ca615acf2ae2c1ee3c1c643492cb04f42b10984fa9aacff1420dc829fd82f93ad3476fbd0cdab0251142c887dc8f872d03e39a3a3eb6d381"
     },
-    "signature": "qpDddYGgAKNR3TszOgjPXRphUl2P9Ym5OQaetltocgZASGDkOun5D64+1D0QJRKb4SG2+48muxGOHyL2Ngos4NUrrSR+SIkywZacay82YQBCEdr7\/4MjW1WHRPjvboLwEJwViw0EdAjsWRpD68aPnzUGrGsy2BsCo06P5iwjk9cXcHxdjC9R39npvoC3QNvQ2jmNIbh1Lc4U97dbb+CsXEQCLU1OSa9p3q6cEFV98Easwt7uF\/DzHK+CbeZlxVZ0DwLh2\/ylT1PyGou8QC1b3vKAnPjLWMO+UsCPpCKhk3C5pV+5etQ8puGd+0x2t5tEU+qXxLzek91zWNC+rqgC\/WlqLKbwPb\/BCHs4zLGV55Q2fEQmT21x0KCUELdPs4dBnYP4Ox5tEDugtJujWFzOHzoY6gGa\/BY\/78pSZXmq9o8dWkBEtioWWvaNZ1rM0ddE83GBlBTgjigi9Ay1D++bUW\/FCBB7CMk6qyNlV81H+cBuIEODw2aymmkM9LLDD2Qbmvo8gHEPRjiQxPC5OpDlcdSNiL+zcxVxeuX4FpT+9xzz\/\/DRONhufxRpsbuCOMxd96RW7y9U2N2Uxb3Bzn\/BIqEayUUsdgZjfaGcXXYKR+chu\/LOwNYN6RlnLsgqL\/dhGKwlRVKXw1RA2\/af\/CpqyR7uVP6al1YJo\/YJ+5XJ6zE=",
+    "signature": "JW6+PIg2L2GC4qlK+mmCWsvPrrZG2qR0qetow008cyYRF2KHTceCKfU\/BgJXRtLM44WGiQpq5EAUdPqxvYvzV5xmW11X+Ny6Hv\/NEdG1BtwCUq+hlNZWMXDZUMhgHu4mNH\/eHWuo89UJzvsQ0S2g7KNZznfHORmaLmaCwu0526OjJ6VoSfdGJVn3OkEGqljnNqJnSDs6DXHC4VZlamu\/OJKvo2OBrZUQ7JIAWOEhnQyCSi\/G0S4nPw9X8sR6sosao3kLr0rTmBZOUssxPheBQCmAwaGllI6LGbgUSALok7oNKaRR6ynFFlnZNMNliyqqoYhs5\/tOFoeBwpoPKex+EnHoMjryjwKwrr5xvaDS8\/FfYeBVjsA0SbvVQWqX4h3DojKb3sX643P2SAxtdaeK8NX3CdC9qVrJK8pXY18rVTsoNDd2EKmMpWj9o+s05cxPGAhLauGRA1VIi9PKvmb9nlOj5oKMshOLK+sIK5EWnqv6zw1C8VsdUafC\/ukSDP0Z8RmxOa\/NzvMH8yW3zewKIGI4byWdEvyafcayhg1zLlBdph2\/NSbTEA0r5qKOMNmnxWAPjF+YRoKIEgpE3lDTQMOcB57lVgPu2TdOosY+1P2A554Q8qO2geo6KE782BVVb0aOkr5cHUmUGujFeCiLcsAoksuiQGjXtiSGwAX2qcQ=",
     "certificate": "-----BEGIN CERTIFICATE-----\r\nMIIEvjCCAqagAwIBAgIUc\/0FxYrsgSs9rDxp03EJmbjN0NwwDQYJKoZIhvcNAQEF\r\nBQAwIzEhMB8GA1UECgwYb3duQ2xvdWQgQ29kZSBTaWduaW5nIENBMB4XDTE1MTEw\r\nMzIxMDMzM1oXDTE2MTEwMzIxMDMzM1owDzENMAsGA1UEAwwEY29yZTCCAiIwDQYJ\r\nKoZIhvcNAQEBBQADggIPADCCAgoCggIBALb6EgHpkAqZbO5vRO8XSh7G7XGWHw5s\r\niOf4RwPXR6SE9bWZEm\/b72SfWk\/\/J6AbrD8WiOzBuT\/ODy6k5T1arEdHO+Pux0W1\r\nMxYJJI4kH74KKgMpC0SB0Rt+8WrMqV1r3hhJ46df6Xr\/xolP3oD+eLbShPcblhdS\r\nVtkZEkoev8Sh6L2wDCeHDyPxzvj1w2dTdGVO9Kztn0xIlyfEBakqvBWtcxyi3Ln0\r\nklnxlMx3tPDUE4kqvpia9qNiB1AN2PV93eNr5\/2riAzIssMFSCarWCx0AKYb54+d\r\nxLpcYFyqPJ0ydBCkF78DD45RCZet6PNYkdzgbqlUWEGGomkuDoJbBg4wzgzO0D77\r\nH87KFhYW8tKFFvF1V3AHl\/sFQ9tDHaxM9Y0pZ2jPp\/ccdiqnmdkBxBDqsiRvHvVB\r\nCn6qpb4vWGFC7vHOBfYspmEL1zLlKXZv3ezMZEZw7O9ZvUP3VO\/wAtd2vUW8UFiq\r\ns2v1QnNLN6jNh51obcwmrBvWhJy9vQIdtIjQbDxqWTHh1zUSrw9wrlklCBZ\/zrM0\r\ni8nfCFwTxWRxp3H9KoECzO\/zS5R5KIS7s3\/wq\/w9T2Ie4rcecgXwDizwnn0C\/aKc\r\nbDIjujpL1s9HO05pcD\/V3wKcPZ1izymBkmMyIbL52iRVN5FTVHeZdXPpFuq+CTQJ\r\nQ238lC+A\/KOVAgMBAAEwDQYJKoZIhvcNAQEFBQADggIBAGoKTnh8RfJV4sQItVC2\r\nAvfJagkrIqZ3iiQTUBQGTKBsTnAqE1H7QgUSV9vSd+8rgvHkyZsRjmtyR1e3A6Ji\r\noNCXUbExC\/0iCPUqdHZIVb+Lc\/vWuv4ByFMybGPydgtLoEUX2ZrKFWmcgZFDUSRd\r\n9Uj26vtUhCC4bU4jgu6hIrR9IuxOBLQUxGTRZyAcXvj7obqRAEZwFAKQgFpfpqTb\r\nH+kjcbZSaAlLVSF7vBc1syyI8RGYbqpwvtREqJtl5IEIwe6huEqJ3zPnlP2th\/55\r\ncf3Fovj6JJgbb9XFxrdnsOsDOu\/tpnaRWlvv5ib4+SzG5wWFT5UUEo4Wg2STQiiX\r\nuVSRQxK1LE1yg84bs3NZk9FSQh4B8vZVuRr5FaJsZZkwlFlhRO\/\/+TJtXRbyNgsf\r\noMRZGi8DLGU2SGEAHcRH\/QZHq\/XDUWVzdxrSBYcy7GSpT7UDVzGv1rEJUrn5veP1\r\n0KmauAqtiIaYRm4f6YBsn0INcZxzIPZ0p8qFtVZBPeHhvQtvOt0iXI\/XUxEWOa2F\r\nK2EqhErgMK\/N07U1JJJay5tYZRtvkGq46oP\/5kQG8hYST0MDK6VihJoPpvCmAm4E\r\npEYKQ96x6A4EH9Y9mZlYozH\/eqmxPbTK8n89\/p7Ydun4rI+B2iiLnY8REWWy6+UQ\r\nV204fGUkJqW5CrKy3P3XvY9X\r\n-----END CERTIFICATE-----"
 }'

/drone/src/github.com/nextcloud/server/lib/private/IntegrityCheck/Checker.php:300
/drone/src/github.com/nextcloud/server/tests/lib/IntegrityCheck/CheckerTest.php:523

10) Test\IntegrityCheck\CheckerTest::testWriteCoreSignatureWithValidModifiedHtaccessAndUserIni
Expectation failed for method name is equal to <string:file_put_contents> when invoked 1 time(s)
Parameter 1 for invocation OC\IntegrityCheck\Helpers\FileAccessHelper::file_put_contents('/drone/src/github.com/nextclo...e.json', '{\n    "hashes": {\n        ".h...---"\n}') does not match expected value.
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
     },
-    "signature": "d6pqYc0pj5hihZK4Pi\/rM9XguY1xK9LEch+jUcxZWwhzOPL4qVHx5LN4FAhEOnr5ZjuhK\/umVEUjieamF4z8tP\/4nnnu2LmRuPMmj6+1tBEwbsKoeg7NiYfYL5h+VSdBePpIZDmjk0tjEpsMtCPhUPAY5vOSSDJ3Xef4KQIpeL6RKIctDcVdO26QWPLFpCo9NK3j91KHuXTcjbAsATDo+oXQzi0CaomBqL6Ft1SU\/Bdes6usgeVWd6mGygZ6zUCLqB4hSi6335xIkkUO1c3NekWksiqTWqdmVIpsTEsIpapx+nE0UFBGc7ZF2rnamg5813g67M5V\/UwhBRcHobMFWfbp73QDUsHcuLCOhamgYh7hbVIlDP7LS2V3kIRLgMLBVwLnvb8LAbaGUsdYGtbfmrhcMK\/jkpGCv0pqUCc4I+1QuVexNEQrdqafwYRnQUsmdFSFaCASYVvgxPrY5jA+y1HwNX5HEc5mMzVORNPhZXUcxWBRUQxUESY5j473DInMQUhq7SLVNAaglxDR1a9M5tQO8engvIJ5eTImLITm0qdefmEvFrxQ0BrrGmPNFYUysrHeNGDhMkGX+JIONj+T4Ht3Z7dr7cfufYDHRaummsTGgRx6206zRSqavsBWL\/Cbzrfu1HhiRagncVcoL40EommJt8lobaKHs3GZ8k861Wo=",
+    "signature": "KJSL9WOXst7zt5jb+xa2X\/f7O6QmD2J9KPtcFbJ7OnpOoqgonmzszggyS1u3ZmHSbvAJuMz++iZCv+kG3mkJi8qh0Wqlxr7PKghb5srtuQFQz0MIkSK3Bqt4NDgXNqkV3r6nEXISkMNRivTMMkGs8cZt\/WXmZ\/tV5tmPcemHawCv49\/L3bwkIXDUCtvf2k17Mc+8fMnXDxsVN3lf+o1RdhqyUz3zb3E+4Uj1gp3dKpKOZdfQryOArEKJITpnnmPJ\/bpeWYU4purw9evf6VoguUq0KWoMEUNcSNd\/KLgsf85CRzUgcn4ey8n6Anvq60qukDTJMc7FB9NXRI8GJD08ujEWD+vQ+wFA6q4AmDEFhkonk8HkblasFfWCLeEZt\/efR0BuIlYaAqIDAI\/dUogXHYlShlepk1k1GiS0KDNuv7IILKk3LDjO9IxSzRzw6047DmNni6vFWId10oQqS3EzXc6wbQ3l7o7+iFQ8JtdodIC6Eq6YiC4in1rUwms1AlWesb58mrJ25tocmRmCb2haaXilUeqmTlXyYWdB03u6ZWhe8XTAbGEULZ7+x3za4OTLgYE\/0gbgKo+bExIIG9cglI9+nxxz6qUnCfnnA2RD9jKqsXZH\/5Z1T3ClJ0L33GaOfXxxShjhdUYL+jSxOg5FuCJ2Nond51CwZUc9fRAhb+Q=",
     "certificate": "-----BEGIN CERTIFICATE-----\r\nMIIEvjCCAqagAwIBAgIUc\/0FxYrsgSs9rDxp03EJmbjN0NwwDQYJKoZIhvcNAQEF\r\nBQAwIzEhMB8GA1UECgwYb3duQ2xvdWQgQ29kZSBTaWduaW5nIENBMB4XDTE1MTEw\r\nMzIxMDMzM1oXDTE2MTEwMzIxMDMzM1owDzENMAsGA1UEAwwEY29yZTCCAiIwDQYJ\r\nKoZIhvcNAQEBBQADggIPADCCAgoCggIBALb6EgHpkAqZbO5vRO8XSh7G7XGWHw5s\r\niOf4RwPXR6SE9bWZEm\/b72SfWk\/\/J6AbrD8WiOzBuT\/ODy6k5T1arEdHO+Pux0W1\r\nMxYJJI4kH74KKgMpC0SB0Rt+8WrMqV1r3hhJ46df6Xr\/xolP3oD+eLbShPcblhdS\r\nVtkZEkoev8Sh6L2wDCeHDyPxzvj1w2dTdGVO9Kztn0xIlyfEBakqvBWtcxyi3Ln0\r\nklnxlMx3tPDUE4kqvpia9qNiB1AN2PV93eNr5\/2riAzIssMFSCarWCx0AKYb54+d\r\nxLpcYFyqPJ0ydBCkF78DD45RCZet6PNYkdzgbqlUWEGGomkuDoJbBg4wzgzO0D77\r\nH87KFhYW8tKFFvF1V3AHl\/sFQ9tDHaxM9Y0pZ2jPp\/ccdiqnmdkBxBDqsiRvHvVB\r\nCn6qpb4vWGFC7vHOBfYspmEL1zLlKXZv3ezMZEZw7O9ZvUP3VO\/wAtd2vUW8UFiq\r\ns2v1QnNLN6jNh51obcwmrBvWhJy9vQIdtIjQbDxqWTHh1zUSrw9wrlklCBZ\/zrM0\r\ni8nfCFwTxWRxp3H9KoECzO\/zS5R5KIS7s3\/wq\/w9T2Ie4rcecgXwDizwnn0C\/aKc\r\nbDIjujpL1s9HO05pcD\/V3wKcPZ1izymBkmMyIbL52iRVN5FTVHeZdXPpFuq+CTQJ\r\nQ238lC+A\/KOVAgMBAAEwDQYJKoZIhvcNAQEFBQADggIBAGoKTnh8RfJV4sQItVC2\r\nAvfJagkrIqZ3iiQTUBQGTKBsTnAqE1H7QgUSV9vSd+8rgvHkyZsRjmtyR1e3A6Ji\r\noNCXUbExC\/0iCPUqdHZIVb+Lc\/vWuv4ByFMybGPydgtLoEUX2ZrKFWmcgZFDUSRd\r\n9Uj26vtUhCC4bU4jgu6hIrR9IuxOBLQUxGTRZyAcXvj7obqRAEZwFAKQgFpfpqTb\r\nH+kjcbZSaAlLVSF7vBc1syyI8RGYbqpwvtREqJtl5IEIwe6huEqJ3zPnlP2th\/55\r\ncf3Fovj6JJgbb9XFxrdnsOsDOu\/tpnaRWlvv5ib4+SzG5wWFT5UUEo4Wg2STQiiX\r\nuVSRQxK1LE1yg84bs3NZk9FSQh4B8vZVuRr5FaJsZZkwlFlhRO\/\/+TJtXRbyNgsf\r\noMRZGi8DLGU2SGEAHcRH\/QZHq\/XDUWVzdxrSBYcy7GSpT7UDVzGv1rEJUrn5veP1\r\n0KmauAqtiIaYRm4f6YBsn0INcZxzIPZ0p8qFtVZBPeHhvQtvOt0iXI\/XUxEWOa2F\r\nK2EqhErgMK\/N07U1JJJay5tYZRtvkGq46oP\/5kQG8hYST0MDK6VihJoPpvCmAm4E\r\npEYKQ96x6A4EH9Y9mZlYozH\/eqmxPbTK8n89\/p7Ydun4rI+B2iiLnY8REWWy6+UQ\r\nV204fGUkJqW5CrKy3P3XvY9X\r\n-----END CERTIFICATE-----"
 }'

/drone/src/github.com/nextcloud/server/lib/private/IntegrityCheck/Checker.php:300
/drone/src/github.com/nextcloud/server/tests/lib/IntegrityCheck/CheckerTest.php:554

11) Test\IntegrityCheck\CheckerTest::testVerifyCoreSignatureWithValidSignatureData
Failed asserting that Array &0 (
    'EXCEPTION' => Array &1 (
        'class' => 'OC\IntegrityCheck\Exceptions\InvalidSignatureException'
        'message' => 'Signature could not get verified.'
    )
) is identical to Array &0 ().

/drone/src/github.com/nextcloud/server/tests/lib/IntegrityCheck/CheckerTest.php:615

12) Test\IntegrityCheck\CheckerTest::testVerifyCoreSignatureWithValidModifiedHtaccessAndUserIniSignatureData
Failed asserting that Array &0 (
    'EXCEPTION' => Array &1 (
        'class' => 'OC\IntegrityCheck\Exceptions\InvalidSignatureException'
        'message' => 'Signature could not get verified.'
    )
) is identical to Array &0 ().

/drone/src/github.com/nextcloud/server/tests/lib/IntegrityCheck/CheckerTest.php:657

13) Test\IntegrityCheck\CheckerTest::testVerifyCoreSignatureWithValidSignatureDataAndNotAlphabeticOrder
Failed asserting that Array &0 (
    'EXCEPTION' => Array &1 (
        'class' => 'OC\IntegrityCheck\Exceptions\InvalidSignatureException'
        'message' => 'Signature could not get verified.'
    )
) is identical to Array &0 ().

/drone/src/github.com/nextcloud/server/tests/lib/IntegrityCheck/CheckerTest.php:698

14) Test\IntegrityCheck\CheckerTest::testVerifyCoreSignatureWithTamperedFiles
Failed asserting that Array &0 (
    'EXCEPTION' => Array &1 (
        'class' => 'OC\IntegrityCheck\Exceptions\InvalidSignatureException'
        'message' => 'Signature could not get verified.'
    )
) is identical to Array &0 (
    'INVALID_HASH' => Array &1 (
        'AnotherFile.txt' => Array &2 (
            'expected' => '1570ca9420e37629de4328f48c51da29840ddeaa03ae733da4bf1d854b8364f594aac560601270f9e1797ed4cd57c1aea87bf44cf4245295c94f2e935a2f0112'
            'current' => '7322348ba269c6d5522efe02f424fa3a0da319a7cd9c33142a5afe32a2d9af2da3a411f086fcfc96ff4301ea566f481dba0960c2abeef3594c4d930462f6584c'
        )
    )
    'FILE_MISSING' => Array &3 (
        'subfolder/file.txt' => Array &4 (
            'expected' => '410738545fb623c0a5c8a71f561e48ea69e3ada0981a455e920a5ae9bf17c6831ae654df324f9328ff8453de179276ae51931cca0fa71fe8ccde6c083ca0574b'
            'current' => ''
        )
    )
    'EXTRA_FILE' => Array &5 (
        'UnecessaryFile' => Array &6 (
            'expected' => ''
            'current' => 'cf83e1357eefb8bdf1542850d66d8007d620e4050b5715dc83f4a921d36ce9ce47d0d13c5d85f2b0ff8318d2877eec2f63b931bd47417a81a538327af927da3e'
        )
    )
).

/drone/src/github.com/nextcloud/server/tests/lib/IntegrityCheck/CheckerTest.php:807

15) Test\IntegrityCheck\CheckerTest::testVerifyCoreWithDifferentScope
Failed asserting that Array &0 (
    'EXCEPTION' => Array &1 (
        'class' => 'PHPUnit_Framework_Error_Notice'
        'message' => 'Array to string conversion'
    )
) is identical to Array &0 (
    'EXCEPTION' => Array &1 (
        'class' => 'OC\IntegrityCheck\Exceptions\InvalidSignatureException'
        'message' => 'Certificate is not valid for required scope. (Requested: core, current: CN=SomeApp)'
    )
).

/drone/src/github.com/nextcloud/server/tests/lib/IntegrityCheck/CheckerTest.php:901

LukasReschke · 2016-08-19T11:16:31Z

As #836 (comment) says 😉 – This is caused by an change in phpseclib behaviour. Need to think about how to handle this…

MorrisJobke · 2016-09-07T15:29:57Z

.htaccess

+#### DO NOT CHANGE ANYTHING ABOVE THIS LINE ####
+
+ErrorDocument 403 /core/templates/403.php
+ErrorDocument 404 /core/templates/404.php


Ah... bad autotests.sh touching that file all the time.

MorrisJobke · 2016-09-07T15:30:57Z

@rullzer Is this ready for review?

rullzer · 2016-09-07T18:41:47Z

Nope it is an ugly ugly work around. But i have ideas on how to clean up a bit.. Will do soonish

rullzer · 2016-09-07T19:29:02Z

Ok ready for reviews. See https://tools.ietf.org/html/rfc3447#page-38 for the salt length of 0.
This salt length of 0 makes the signature deterministic.

LukasReschke · 2016-09-07T20:01:16Z

LGTM

* Set salt length to 0 See https://tools.ietf.org/html/rfc3447#page-38 * Fix tests for new phpunit

LukasReschke · 2016-09-07T20:10:08Z

Rebased on top of merged 3rdparty and fixed a merge conflict

Bumps the PHP version from beta2 to RC1

LukasReschke · 2016-09-07T20:36:09Z

Failing on the updated PHP 7.1 RC1, the errors are strange though. Mhm. 🙈

https://drone.weasel.rocks/nextcloud/server/1551

LukasReschke · 2016-09-07T20:42:15Z

Seems like JSON_PRETTY_PRINT behaves differently now…

In php 7.1 the pretty print json output changed. Thus now we compare arrays.

MorrisJobke · 2016-09-07T21:10:46Z

Looks good 👍

MorrisJobke · 2016-09-08T07:27:59Z

🎉

LukasReschke added the 2. developing Work in progress label Aug 11, 2016

LukasReschke added this to the Nextcloud 11.0 milestone Aug 11, 2016

LukasReschke mentioned this pull request Aug 18, 2016

[WIP] Update to phpseclib 2.0.3 nextcloud/3rdparty#8

Merged

LukasReschke force-pushed the php7.1 branch from f991f20 to f17e82a Compare August 18, 2016 20:04

rullzer force-pushed the php7.1 branch from a027e71 to ee82647 Compare September 6, 2016 08:52

MorrisJobke reviewed Sep 7, 2016
View reviewed changes

rullzer force-pushed the php7.1 branch from ee82647 to 32a4703 Compare September 7, 2016 19:08

rullzer added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 7, 2016

LukasReschke and others added 7 commits September 7, 2016 22:09

Add PHP 7.1 drone tests

9915f68

$this->blackListedClassNames is unknown

aa10231

Initialize array elements properly

1631ef5

Use updated phpseclib ref

1937e6e

Fix intergrity checker

fb4850f

* Set salt length to 0 See https://tools.ietf.org/html/rfc3447#page-38 * Fix tests for new phpunit

Set default

1cdf4e9

Update 3rdparty ref

d4cbc24

LukasReschke force-pushed the php7.1 branch from 32a4703 to d4cbc24 Compare September 7, 2016 20:09

Use the PHP 7.1-3 tag

1b2021a

Bumps the PHP version from beta2 to RC1

Compare arrays not json strings

9d00f36

In php 7.1 the pretty print json output changed. Thus now we compare arrays.

LukasReschke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 7, 2016

rullzer mentioned this pull request Sep 7, 2016

[3rdparty] PasswordCompat is no longer required #1315

Merged

2 tasks

LukasReschke merged commit ff691b4 into master Sep 8, 2016

LukasReschke deleted the php7.1 branch September 8, 2016 07:20

Uh oh!

Conversation

LukasReschke commented Aug 11, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mention-bot commented Aug 11, 2016

Uh oh!

LukasReschke commented Aug 11, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LukasReschke commented Aug 11, 2016 • edited by MorrisJobke Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LukasReschke commented Aug 11, 2016

Uh oh!

LukasReschke commented Aug 18, 2016

Uh oh!

MorrisJobke commented Aug 19, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LukasReschke commented Aug 19, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MorrisJobke Sep 7, 2016

Choose a reason for hiding this comment

Uh oh!

rullzer Sep 7, 2016

Choose a reason for hiding this comment

Uh oh!

MorrisJobke commented Sep 7, 2016

Uh oh!

rullzer commented Sep 7, 2016

Uh oh!

rullzer commented Sep 7, 2016

Uh oh!

LukasReschke commented Sep 7, 2016

Uh oh!

LukasReschke commented Sep 7, 2016

Uh oh!

LukasReschke commented Sep 7, 2016

Uh oh!

LukasReschke commented Sep 7, 2016

Uh oh!

MorrisJobke commented Sep 7, 2016

Uh oh!

MorrisJobke commented Sep 8, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

LukasReschke commented Aug 11, 2016 •

edited

Loading

LukasReschke commented Aug 11, 2016 •

edited

Loading

LukasReschke commented Aug 11, 2016 •

edited by MorrisJobke

Loading

MorrisJobke commented Aug 19, 2016 •

edited

Loading

LukasReschke commented Aug 19, 2016 •

edited

Loading