LDAP Sync fixes: revert recursion resolution, fixed handling of pagingsize of 0#7796
Merged
MorrisJobke merged 4 commits intomasterfrom Jan 11, 2018
Merged
LDAP Sync fixes: revert recursion resolution, fixed handling of pagingsize of 0#7796MorrisJobke merged 4 commits intomasterfrom
MorrisJobke merged 4 commits intomasterfrom
Conversation
thus hasMoreResult should return false Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
The message is not helpful anyway for an admin, and oftentimes is just valid (e.g. when searching with an offset beyond users in LDAP). Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
without recursion we have issues with internal states. paged search status are set to false, cookies are not being set. In the end we have endless requests which pile up enormously with a high initial offset. Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Codecov Report
@@ Coverage Diff @@
## master #7796 +/- ##
============================================
+ Coverage 51.22% 51.23% +<.01%
Complexity 24970 24970
============================================
Files 1607 1607
Lines 95011 95008 -3
Branches 1376 1376
============================================
- Hits 48674 48673 -1
+ Misses 46337 46335 -2
|
MorrisJobke
approved these changes
Jan 11, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So, we still encountered to see a lot of log messages on our instances, and with some more debug output I could trace it back. The main issue here is that resolving a recursion during LDAP search (happens with an initial offset > 0) didn't work out as expected, due to some internal state issues. It was not obvious with low offset, but it can pile up unnicely.
Additionally to it comes some by catch with tests.