Conversation
danxuliu
left a comment
There was a problem hiding this comment.
As mentioned in #7414 the length should be tested against the plain text mentions instead of the rich text ones, but if you prefer to fix that in a different pull request (and the other silently failing unit tests ;-) ) fine by me ;-)
|
@danxuliu if you are up for it feel free to push commits here ;) |
Let's do this in a separate PR and merge after the restarted CI job finished: https://drone.nextcloud.com/nextcloud/server/3597 |
Fixes #7414 Since we no longer use an input field we have to use text instead of val. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Codecov Report
@@ Coverage Diff @@
## master #7648 +/- ##
=========================================
Coverage 51.17% 51.17%
Complexity 24886 24886
=========================================
Files 1602 1602
Lines 94752 94752
Branches 1368 1368
=========================================
Hits 48486 48486
Misses 46266 46266
|
Fixes #7414
Since we no longer use an input field we have to use text instead of
val.
I basically just followed the debug session written down by @danxuliu in #7414 :)