Conversation
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
added
3. to review
Member
|
It’s fine by me. :) But FYI on mobile there’s a scrollbar very early (which was the issue originally to be solved by this whole working on the log in screen I think ;) |
Member
Author
|
@jancborchardt what kind of mobile is this? This looks very small! :/ EDIT there is an empty div which is 70px high named '.push', any idea why it's there? @jancborchardt |
Member
|
@skjnldsv it’s Firefox responsive design mode, but looks the same on a Fairphone 2 for example (5" screen). And keep in mind the keyboard will also be shown there. |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Codecov Report
@@ Coverage Diff @@
## master #7470 +/- ##
=========================================
Coverage 51.11% 51.11%
Complexity 24900 24900
=========================================
Files 1601 1601
Lines 94772 94772
Branches 1367 1367
=========================================
Hits 48438 48438
Misses 46334 46334 |
Member
Author
|
Okay, fixed, It was an old div designed to push the footer 😱 |
jancborchardt
approved these changes
Dec 12, 2017
Member
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
Looks good to me now! 🚀 :)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #7249