Give audio-white and audio-off-white shadow via CSS#7247
Merged
jancborchardt merged 1 commit intomasterfrom Nov 22, 2017
Merged
Give audio-white and audio-off-white shadow via CSS#7247jancborchardt merged 1 commit intomasterfrom
jancborchardt merged 1 commit intomasterfrom
Conversation
Signed-off-by: Marin Treselj <marin@pixelipo.com>
pixelipo
added
3. to review
skjnldsv
approved these changes
Nov 22, 2017
Codecov Report
@@ Coverage Diff @@
## master #7247 +/- ##
============================================
+ Coverage 50.84% 50.84% +<.01%
Complexity 24548 24548
============================================
Files 1585 1585
Lines 93804 93804
Branches 1354 1354
============================================
+ Hits 47693 47697 +4
+ Misses 46111 46107 -4
|
jancborchardt
approved these changes
Nov 22, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes regression #7243
audio-white and audio-off-white should be visible in Talk app when video is disabled (thanks to shadow).
This introduces new class
.icon-shadowthat can be use on any icon. Other icons that (still) have SVG shadow filters will be migrated to this solution in a subsequent PR, because only this one is critical.To be reviewed and merged with nextcloud/spreed#501